Open eyal0 opened 6 years ago
Hello again, After 10 hours prints i had some time to look a bit deeper (and also updated to latest 1.1.4). I Sent M503 manually. first thing to notice is that the Acceleration (M204) in PTG log is different than that of my firmware and M92 which is nowhere to be found. My firmware acceleration is set to 750 and in PTG log file reads S500. i can look for other settings but it seems there is an issue here. i can check the rest later today. Correct me if I'm wrong but it seem that PTG does not work in my case.
BTW: what mechanism sends M503 before printing? i don't see it in OctoPrint nor in your plug settings. does this happens behind the scenes during connection?
First, from looking at the output of the M503, everything looks fine. I don't see any weirdness in the output from M503 that would make me think that PTG would fail to pick-up all the necessary Mcodes. So I'd expect it to work, yet it isn't.
You ask what mechanism sends M503. The answer is: I don't know. I use a marlin printer and everytime I connect to the printer, M503 output appears on the screen. I don't know how. I just assumed that it was OctoPrint but maybe it isn't. Can you test this? On OctoPrint, with the terminal open, disconnect from the printer and then reconnect. Let me know if the printer spews all the M503 output. Maybe it's just a feature unique to Marlin, that marlin is doing on OctoPrint's behalf? If so, I can modify PTG to make it always do an M503 at printer connect. No biggie.
Now, even if the printer doesn't do M503 at startup, any M503 issued ought to update the config. Even if you just type it in yourself, which you did! So I would expect that if you type an M503 and then wait 5 seconds and then analyze a file, the PTG log will show all those correct settings getting send to marlin-calc so that it can run an accurate simulation. Could you try that? Do an M503 from the terminal. Wait until the output is finished spewing in the terminal. Then go to the PTG settings and manually analyze a file. And finally, find the log output for that manually analyzed file and see if the arguments to marlin-calc match what you see in M503 output. (it won't have all lines, just M200-M206 and M92, I think. But not all, most are irrelevant to speed calcuation.) If you see a mismatch between what it shows in the log and what it shows in M503, that means PTG isn't properly reading the M503 info and saving it. I'll have to figure out why. If there are error messages in the log, I would want to know about those, too!
And finally, after we sort all that out and marlin-calc is running with the right M200-M205 and M92 values, I want to see what estimates marlin-calc is giving. I expect them to be really close to the actual print time, not of by about 9% like you've been experiencing. If after getting all the right values marlin-calc is still inaccurate then I want to try gcodestat and see if it's any better.
So, you've got tasks! :smile: Here you go:
Thanks for your help! We'll make PTG better for everyone together!
Your wishes are my commands. I see both progress and a sort of a regression.
The good news is: I now see a much more realistic time estimation using the very same g-code which I executed last night. last night it was reading ~3hr print time, but ended up to be like 4hr. today, after sending manually M503 command and reloading this very same gcode - it reads:
AIRV2_v4.gcode Internal: AIRV2_v4.gcode Uploaded: a few seconds ago Size: 7.9MB Model size: 225.89mm × 215.45mm × 14.70mm Filament: 26.09m / 184.45cm³ Estimated print time: 04:09:54
These are good news! it means a change for the better which i need to learn and figure it out. what puzzles me is this: i wanted to load PTG before initiating M503 and compare the result with a gcode which was loaded after M503. the good and bad news is that it appears that once initiating M503 manually - it is in memory somehow. no matter what i tried: RESET the board, restart OP, clear PTG analyzer - nothing got me back to square one to see how it loads without M503. I don't know how computers think so I will leave it at that.
Now for the "bad" news: i recently upgraded to 1.1.4. then loaded a gcode to see what i get and .. nothing. no matter what i tried i did not get PTG to generate this gold-star icon so my first impression was that 1.1.4 gone sour on me, so I had to downgrade to 1.1.3 dev and .. Nope. it did not work either. So, I left my desk to cool down and when i got back this gold-star was shining upon me - WTH?
to make a long story short - it now takes much longer to calculate an 8Mb gcode file. it takes no less than 42sec to analyze one single file and i have not yet tried to print while it is doing its thing - i need to test that but i would hate starting a 2hr print and a minute or so into the print to realize it will actually take 4hr - twice as long :)
So.. more tests ahead but i see progress. i think..
Just started a new print. Cura Est: 1h 06min PTG Est: 1h 42min
Actual print time:
So weird. i analyzed the file but still don't see the correct firmware settings in it. Q: when i analyze a file i don't know when the process is finished. no gold-star to indicate that the file is ready to download and such. Once print is done i will upload all the files you've requested.
right after the print was done, i ran M503 manually and then reloaded the same g-code again. this time i get 1h 26min which is exactly the time it took to actually print the file.
I am a bit lost. need guidance.
Before executing M503 (what you see is the print summery - after print is done):
After executing M503 (as you can see i changed the file name to avoid confusion):
PTG memorizes the Mcodes and saves them in the config when OctoPrint shuts down. It loads them up when OctoPrint starts, too. You can find those in ~/.octoprint/config.yaml . That files only gets written when you shutdown OctoPrint and only gets read when OctoPrint is started. So if you want to reset it, you have to shut off OctoPrint, then delete those lines, then start up again. I store it so that you can analyze even before you've connected to OctoPrint.
If you send me the log. I can read from there everything. You can download it midprint, it won't affect printing. It's available in the settings.
It is pretty confusing, so let's break this debugging up into parts.
First, let's figure out if M503 is run when the printer connects. As far as I can tell from my testing, it does not! Marlin just happens to do it automatically when you connect.
That means that I need to add it in. I'm wary to do that because M503 is actually a pretty slow command sometimes, especially if you have a lot of configuration. So I'll make it an option that users can turn on or off. At worst, you run M503 once when you connect and it takes up to 5 seconds, no biggie. For people that connect and disconnect a lot, they can disable it.
Okay, I'll cover that. For now, I need two things from you:
STOPPER2.txt No change to M503 .metadata file includes personal data about all my prints / models so I will not share it here. And i don't understand this analyzing gcode - once you press Analyze you have no clue what goes on and if the generated log file is what you just analyzed. as a user i need more feedback what goes on.
PTG log file contains all my analyzed files so i don't want to attach it here. What i can see is that i must manually send M503. regarding the log, i can see on some of the files that it did pick up my firmware settings, like:
_AIROSOL_V2v3.gcode" "M221 S105 M205 S0.00000 X0.10000 Z1.00000 M92 X159.53000 Y159.53000 Z159.53000 E6000.0000 M200 D0.0000 M204 S750.00000 P57988 M203 X666.66669 Y666.66669 Z666.66669 E50.0000"'
These looks to be my fw settings.
And, it seems that even without sending M503, i see in the log the correct settings:
_TRIPOD3-no_M503.gcode" 2018-08-12 17:20:33,827 Running: "/home/pi/oprint/bin/python2" "/home/pi/oprint/lib/python2.7/site-packages/octoprint_PrintTimeGenius/analyzers/analyze_progress.py" "marlin-calc" "/home/pi/.octoprint/uploads/TRIPOD3-noM503.gcode" "M221 S105 M205 S0.00000 X0.10000 Z1.00000 M92 X159.53000 Y159.53000 Z159.53000 E6000.0000 M200 D0.0000 M204 S750.00000 P57988 M203 X666.66669 Y666.66669 Z666.66669 E50.0000" 2018-08-12 17:20:55,490 Subprocess output: Running:
https://github.com/eyal0/OctoPrint-PrintTimeGenius/issues/62#issuecomment-412255356
User's jerk/acceleration/etc settings were not copied correctly from the printer to the printer settings. Not sure why.