search

eyaleizenberg / react-native-custom-action-sheet

React Native custom action sheet
MIT License
179 stars 39 forks source link

CustomActionSheet renders invisible overlay when modelVisible is false #21

Open dchhetri opened 7 years ago

dchhetri commented 7 years ago

When modelVisible is false, it still renders seemingly invisible overlay on the background causing the background not to be interactable. I worked around this by basically rendering this.state.show && <CustomActionSheet modelVisible={this.state.show}>

Kikketer commented 7 years ago

I'm having the same issue, the project has low downloads and may not be maintained. Might be worth a pull request.

conor909 commented 7 years ago

Ad far as I can see this library just uses react-native modal, with an ios styled button below the children inside it. The FadeInView is an opacity animated View, wrapped around the Modal, so it wont work unless the place you trigger the modal is inside a view that covers the whole viewport. I think it's better to use the react-native modal and follow this issue https://github.com/facebook/react-native/issues/12478