eyalroz / bidimailui

BiDi Mail UI: Thunderbird extension for improved right-to-left language support
https://addons.thunderbird.net/en-US/thunderbird/addon/bidi-mail-ui/
Other
18 stars 2 forks source link

Ctrl+Shift+X shortcut for cycling message direction mode broken since TB 102 #103

Closed eyalroz closed 1 year ago

eyalroz commented 1 year ago

Ctrl+Shift+X is supposed to execute the cycle message direction mode command. It is injected using the WindowListener mechanism, like so:

  WL.injectElements(`
    <keyset id="mailKeys">
      <key id="key-bidimailui-cycle"
           modifiers="&key-bidimail-cycle-document-direction.modifiers;"
           key="&key-bidimail-cycle-document-direction.keycode;"
           oncommand="BiDiMailUI.MessageOverlay.cycleDirectionSettings()" />
    </keyset>

and is found in the mailKeys set:

<key id="key-bidimailui-cycle" modifiers="accel,shift" key="X" wlapi_autoinjected="AddOnNS8" oncommand="BiDiMailUI.MessageOverlay.cycleDirectionSettings()"/>

... but pressing Ctrl+Shift+x (or Ctrl+Shift+X) does nothing. No error messages either.

eyalroz commented 1 year ago

Resolved - since the messagePane issue was resolved by another commit.