Open eyalroz opened 1 month ago
I've asked for a code review of my unique_span class, on codereviews.stackexchange.com, and got one.
Issues brought up:
swap()
T
release()
noexcept
Well, my decision about all of those:
{}
Some issues can't be fully addressed due to the use of the "poor man's span" with earlier C++ versions, as the base class.
I've asked for a code review of my unique_span class, on codereviews.stackexchange.com, and got one.
Issues brought up:
swap()
T
to a span of constT
.release()
isnoexcept
... so making any of our [move] constructorsnoexcept
is a leap of faith.Well, my decision about all of those:
{}
is a bit confusing for the reader, IMHO, so let's keep that part explicit.edit: see #678 .