eyalroz / removedupes

Remove Duplicate Messages
https://addons.thunderbird.net/en-US/thunderbird/addon/removedupes/
Other
87 stars 6 forks source link

Searching duplicates on tree removes all messages from first folder #208

Open MichaKersloot opened 7 months ago

MichaKersloot commented 7 months ago

When searching a folder tree for duplicates, it finds a lot of them, but when deleting the duplicates all and only the messages are deleted from the first folder.

2024-02-13 18_38_30-Duplicate message review

KC-T commented 4 months ago

I am using Thunderbird 115.11.0 (64-bit) and Remove Duplicates 0.5.4b5.

I have similar problems.

I have a lot of duplicated folders. Executing Remove Duplicates can only scan through a small number of folders, and report duplicates up to not more than 2000 messages. Using the pop up window in the last message as an example. "1414" should mean the total number of duplicates found, not just in folder "Bart". However, the pop up window appeared only once to ask for confirmation of deletion, while past version can pop up many windows for the many folders. The messages actually deleted are much less than the reported "1414". It means that I have to execute Remove Duplicates many times. This should be a bug to be fixed.

eyalroz commented 4 months ago

Hello @MichaKersloot ,

First - I apologize for not attending to bug reports recently. There is a war here in Palestine, and I am very busy trying to organize resistance and opposition to the Israeli onslaught.

Anyway, duplicate deletion only deletes the selected messages; and by default, one message from each set. You can make a manual selection, or use a different sort order and press "Select First" or "Select Last".

Are you seeing cases of deletion which disagree with the selection?

@KC-T : You're describing a different issues. Please open one.

KC-T commented 4 months ago

@eyalroz

It is sad to have the war there hurting many people. I am now using eM Client deduplicate function to remove duplicates. Hope that you can be back to normal life soon.

MichaKersloot commented 4 months ago

Hello @eyalroz

Sorry to hear about your situation. In my case it was a 'one-off' and I don't have the application / add-on in use at this moment. As I can remember the issue was: Duplicates were found in folders: 'bart' 'burning man' '....'

When deleting all 1414 messages only the duplicates in folder 'bart' are removed.

eyalroz commented 1 month ago

@MichaKersloot : Sorry for the long delay in reply.

That, in itself, may not be a bug. If you have many pairs of dupes, one of which is in folder "Bart" and the other in "Burning Man", it is quite possible that the ones in Bart would be deleted. For example, if the sort order involves the folder name, and the first item in each dupe set is selected - that is exactly what's going to happen. You can select the last item in a dupe set, or manually pick-and-choose what to delete, or change the sort order etc. If that is the case - let us please close this bug.

If you're saying that from pairs of dupes within "Burning Man" nothing is deleted - that would be a bug. In that case, please attach a directory with an mbox file, and a subdirectory with mbox files, so that when searching for dupes on the parent directory, I can reproduce this failure.