search

eyalroz / removedupes

Remove Duplicate Messages
https://addons.thunderbird.net/en-US/thunderbird/addon/removedupes/
Other
87 stars 6 forks source link

Thunderbird 128 ESR compatibility problems #223

Closed tkoeck closed 4 months ago

tkoeck commented 4 months ago

Thunderbird 128 ESR compatibility problems.

eyalroz commented 4 months ago

Yes, you're absolutely right. Unfortunately, I am tied up in protests against the continuing war on Gaza (plus my day job), and have not yet found the time to perform the update. I hope to be able to do so something this month, but no promises.

LamKarThess commented 4 months ago

I think it's time to make the move so that the addon gets compatible with TB128. Your addon is important for many users and they deserve the update.

FrankSchoe commented 4 months ago

I admit - I would also be very happy about the update to TB128. At the same time, I'm always surprised at the boldness with which some commentators demand a service for which they pay nothing. Many apps - like this - are free "gifts" to the community and it is up to the developer to decide if and when they take the time to develop these gifts to the next level.

tkoeck commented 4 months ago

I admit - I would also be very happy about the update to TB128. At the same time, I'm always surprised at the boldness with which some commentators demand a service for which they pay nothing. Many apps - like this - are free "gifts" to the community and it is up to the developer to decide if and when they take the time to develop these gifts to the next level.

Well, yes, there is no 'debt' on the developer side.

That being said, the add-on seems to work after I just edited the manifest file for the newer version. So it doesn't seem to be a big change.

confusedsushi commented 4 months ago

@tkoeck if you already made that change, you might want to create a PR? Then someone might want to create an alpha release for the community for testing. This would take pressure from @eyalroz.

LamKarThess commented 4 months ago

@FrankSchoe @tkoeck As Thunderbird users for many years, we acknowledge the usefulness of some addons such as this and a few others. There is no boldness from the side of the users to ask from the developers to update. The developers themselves, following the philosophy of supporting the open source applications, are obliged to update their apps (if not - this is boldness towards their users). it's also their choice and right to release their apps under subscription payment if they want.

tkoeck commented 4 months ago

@tkoeck if you already made that change, you might want to create a PR? Then someone might want to create an alpha release for the community for testing. This would take pressure from @eyalroz.

I just adjusted the manifest.json in the add-on file (which is just a "zip file") to

"strict_max_version": "135.*"

I didn't test it extensively but it seems to work. If you already installed git on the PC and cloned it, you are welcome to create an MR. Unfortunately, I don't have the tools installed on that specific Windows PC right now.

LamKarThess commented 4 months ago

@tkoeck Thank you very much. Correction done.

eyalroz commented 4 months ago

Please try this build: removedupes_0.6.0_tbird.xpi.zip

(decompress the ZIP to get the XPI).

LamKarThess commented 4 months ago

@eyalroz I get the message " file is corrupt"

eyalroz commented 4 months ago

Perhaps you only renamed it rather than decompressing it?

Anyway, you can also try it through this link maybe:

https://github.com/eyalroz/removedupes/releases/tag/v0.6.0-b1

LamKarThess commented 4 months ago

@eyalroz The same 2024-07-29_135044

LamKarThess commented 4 months ago

@eyalroz I decompressed removedupes_0.6.0_tbird.xpi.zip, I got the .xpi file and installed correctly

LamKarThess commented 4 months ago

@eyalroz I did duplicate some emails and tried. Works fine.

LamKarThess commented 4 months ago

@eyalroz My settings are

2024-07-29_140005

Can I help more?

eyalroz commented 4 months ago

@eyalroz I did duplicate some emails and tried. Works fine.

Can I help more?

Not really. I have not actually made significant changes for TB 128. Uploading this to AMO now.

LamKarThess commented 4 months ago

@eyalroz Thank you very much for your prompt actions. Made TB uders very happy. We all hope for the best of Flag_of_Palestine svg

eyalroz commented 4 months ago

My actions were actually not that prompt... next year, please start poking me when a beta version is out.

As for Palestine - even if the war stopped now, there have been so many deaths and injuries already... and half of Gaza is piles of rubble. It'll take years just to clear away what's been destroyed. It's terrible.

Oh, but perhaps I should mention:

people's lives literally depend on the foreign aid. And - the US had cut all funding to UNRWA (other world states have as well, but they've restored it), which is a huge chunk of its funding, and UNRWA is by far the most active organization helping people on the ground in Gaza. They've also lost many people to Israeli fire.