Calculate dates automatically

eyalroz / technion-iit-thesis

A class for Technion IIT PhD/Masters theses - with a sample thesis using it

37 stars 41 forks source link

Calculate dates automatically #50

Open haggaie opened 2 years ago

haggaie commented 2 years ago

This pull request tries to calculate the Hebrew and Gregorian dates automatically. There are a few notes though:

The hebrewcal package adds an apostrophe before the thousands part of the Hebrew year. Not sure if this is important though.
The English month names in hebrewcal sometimes differ from the Academy spelling in Wikipedia (e.g., Tebeth vs. Tevet).

Issue: #13

eyalroz commented 2 years ago

Hello Haggai,

I'm sorry I've not found the time to attend to the glossary issues over the past couple of months. I'll try to find time to review the PR.

haggaie commented 2 years ago

Don't worry about it—no urgency on my part.

eyalroz commented 2 years ago

@haggaie :

Just filed this to have the month names corrected.

eyalroz commented 2 years ago

So, the polyglossia issue is now fixed, by myself with finishing touches from @jspitz. And a new release should be on CTAN without a few days. I hope to find time to get back to this PR this week.

haggaie commented 2 years ago

Thanks. Let me know how you would like to proceed.

eyalroz commented 2 years ago

So, I just tried this branch with TeXLive 2019, and it failed...

Do you think it's legitimate to expect a newer TeXLive version? Or polyglossia version?

If the answer is yes, we should at least do some sort of version check rather than failing with an obscure polyglossia-related error.

haggaie commented 2 years ago

Actually, I tested it with 2018 😬

In principle, I think it is okay to require a version that is common enough. Debian buster and Ubuntu's latest LTS have versions >= 2020, and overleaf has it too.

As for polyglossia, I agree it would be too much to ask people to upgrade it manually. Maybe we can do a version check to check for the bug fix and revert to the existing behavior if it is missing - require users to pass the date manually. What do you think?