search

eydjey / google-api-dotnet-client

Automatically exported from code.google.com/p/google-api-dotnet-client
Apache License 2.0
0 stars 0 forks source link

Make IResponse, Response implement IDisposable #189

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The IResponse and Response class (may) contain a reference to a Stream which 
should be disposed if no longer in use. Otherwise a major memory overhead might 
occur as those streams are not disposed until the GC gets rid of the IResponse 
objects. 

The change would involve:
- Making the IResponse interface inherit IDisposable
- Add a comment to the return value of Request.GetResponse() which clarifies 
that the IResponse object has to be disposed off once unused
- Wrap all GetResponse calls into "using (IResponse r = ..) { .. }" calls

Original issue reported on code.google.com by mlinder...@gmail.com on 20 Feb 2012 at 10:04

GoogleCodeExporter commented 9 years ago

Original comment by asky...@google.com on 25 Apr 2012 at 7:13

GoogleCodeExporter commented 9 years ago

Original comment by asky...@google.com on 25 Apr 2012 at 7:14

GoogleCodeExporter commented 9 years ago

Original comment by asky...@google.com on 25 Apr 2012 at 7:14

GoogleCodeExporter commented 9 years ago 
Issue 188 has been merged into this issue.

Original comment by asky...@google.com on 25 Apr 2012 at 7:16

GoogleCodeExporter commented 9 years ago

Original comment by pele...@google.com on 13 Apr 2013 at 4:34

GoogleCodeExporter commented 9 years ago

Original comment by pele...@google.com on 10 May 2013 at 9:05

GoogleCodeExporter commented 9 years ago 
With the change of creating a transport layer - 
https://codereview.appspot.com/8596049/ IResponse and IRequest will be deleted

Original comment by pele...@google.com on 17 May 2013 at 6:06

GoogleCodeExporter commented 9 years ago

Original comment by pele...@google.com on 22 May 2013 at 10:43