Better Tulane PR

[outlawhayden]

Hey all -

Thanks for the feedback - sorry the first PR has been such a nightmare. We made a branch on outlawhayden that is the most recent version of eye-on-surveillance/sawt, not ours, and we're going to go through and add all of our changes into your most recent version and see if we can get it working locally in this new context. We're going to be adding a bunch of stuff to it today/tonight, so don't worry about anything in here for a little bit, we will totally ping you when we think we have a workable version.

As well, I'm opening this against your main branch only because I don't have permissions in the EOS one (which is good), but if at some point yall want to merge this into a new branch on your end we think that's probably the best course of action.

[vercel[bot]]

@outlawhayden is attempting to deploy a commit to the Eye on Surveillance Team Team on Vercel.

A member of the Team first needs to authorize it.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sawt	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 6, 2023 3:27pm

[marvinmarnold]

Hey thanks for reworking this. I just added you as a contributor to Github if that helps unblock you at all. Anything you can do to get things stable by tonight would be great. I'd love to be able to spend tomorrow ensuring things are stable.

[outlawhayden]

Awesome - I agree. My goal is to get the getanswer setup working again by the end of the day which is critical, as I think getting the new answers will take overnight if I do it correctly, and then we can populate the db and make sure everything holds together.

We split up so that @mikafur32 is helping stitch together the frontend, and I'm going to take a swing at some of the backend stuff, and hopefully everything lines up nice and neat merging it in.

[marvinmarnold]

@outlawhayden how are things looking? I just finished my day job and have some time to dive in.

[mikafur32]

@outlawhayden how are things looking? I just finished my day job and have some time to dive in.

Believe we've got our side of things in. Looking good. @marvinmarnold do you want to authorize the vercel side and we can look at what the merge is looking like?

[outlawhayden]

howdy - i managed to reconstruct some of my earlier progress, and now the new dataset. is getting processed now/overnight. to do so, i had to comment out some of the external posting and gcloud stuff, but the file i just posted is basically a companion script that reads in a csv of questions from a location, and then just handles the api calls all in a line and saves the output (really should be in bash but im lame). i think we're no longer in triage mode - this pr should just slide right on top of your current stuff on a new branch, and once we have the new data in our db we can do some testing to make sure everything plays nice tomorow

[marvinmarnold]

Great @outlawhayden. I'll approve once Vercel build is passing and you can merge. Then we can at least debug in staging tomorrow and hopefully land in prod tomorrow night.

@mikafur32 you should be able to do yarn build locally to debug build issues.

[mikafur32]

Perfect, am debugging the build now. Double checking one of the UI features that's causing issues. 👍

[mikafur32]

We are running into issues associated with typescript that we were able to bypass with the local run, that throw errors when building. So, we're reformatting a bunch of stuff to fit the typescript specs. It might be a bit later tonight/tomorrow morning before we are able to pass the vercel and fully merge.

[marvinmarnold]

Got it. Good luck. If it's not fixed by the morning, can you summarize the issue and I can take over?

[mikafur32]

@marvinmarnold do you know if Vercel auto-checks or does it have to be rerun? ie: that is that newest commit valid?

[marvinmarnold]

Not sure why it's not auto-running for you. Maybe you have to link your Github to Vercel? Anyways, I just reran it.

[mikafur32]

Also @marvinmarnold , on the topic of the slide/swipeable mechanism for the cards, if you want to take a look and try to implement that, absolutely go full steam ahead. I know you said you think it'd be pretty simple to do, but with finals and everything, I don't think we have the time tomorrow to implement that and verify that it works 100% before Thursday.

[mikafur32]

Not sure why it's not auto-running for you. Maybe you have to link your Github to Vercel? Anyways, I just reran it.

Yeah, I realized my primary email was different than the one I gave you for my github, so I had to change it up.

[mikafur32]

Not sure why it's not auto-running for you. Maybe you have to link your Github to Vercel? Anyways, I just reran it.

Yeah, I realized my primary email was different than the one I gave you for my github, so I had to change it up.

@marvinmarnold, can you double check the verification on our emails for vercel: msison1@tulane.edu and catherine's cbrooks2@tulane.edu

[marvinmarnold]

Invites sent

[marvinmarnold]

You have to click button in email accept the invitation btw.

[marvinmarnold]

Going to bed. ttyl

[mikafur32]

Ok, sweet-- I checked the Vercel build logs and I'm only seeing one error. I was originally building it under npm, which wasn't giving me any errors. I now see that Vercel is using yarn, as am I now, so we should be able to clear that one up this morning.

[mikafur32]

Awesome! So it passed, but we are still going to make a few performance changes before accepting the PR. @marvinmarnold

[mikafur32]

@marvinmarnold, if you want to go ahead and accept the PR so that you can test it out and mess with it, that works. Then, we'll create another PR for any additional changes.

[outlawhayden]

Switched it so we're not merging on to your main - created a new branch called response-rating