search

eyecatchup / SEOstats

SEOstats is a powerful open source PHP library to request a bunch of SEO relevant metrics.
MIT License
1.46k stars 383 forks source link

Use DefaultSettings for curl proxy settings, dynamic proxy/UA settings #129

Closed tholu closed 7 years ago

tholu commented 8 years ago

Should fix issue #123

Changes:

tholu commented 8 years ago

@eyecatchup Are you currently accepting pull requests?

prionkor commented 8 years ago

Some thoughts, Setting proxy in Constant doesn't allow script to change it dynamically. We need some way to set and unset value of proxy.

Can we have something similar for user agent?

tholu commented 8 years ago

@prionkor See my last commit to this pull request, which allows to set it dynamically: https://github.com/eyecatchup/SEOstats/pull/129/commits/be4c91dd5b44e6912982ac038ef25eb176a54605

You can use my fork in composer until this pull request is accepted.

prionkor commented 8 years ago

Got it! Thanks for your quick response :)