eyecatchup / SEOstats

SEOstats is a powerful open source PHP library to request a bunch of SEO relevant metrics.
MIT License
1.46k stars 384 forks source link

[V3] next major version of SeoStats #95

Open ClemensSahs opened 9 years ago

ClemensSahs commented 9 years ago

Hello,

currently I work a little on a possible version 3 of SeoStats. I want check your wishes for a next major version. This is a global discussion I will enjoy your ideas.

here a list of my current progress.

System requirements for version 3:

core feature:

Posible feature:

mnapoli commented 9 years ago

Hi there!

I'm currently refactoring how Piwik (github repo) gets SEO data. It's currently plenty of hardcoded stuff, and I want to turn it into a proper separate repository with OOP, Guzzle, tests, … (current work in progress)

The only real alternative today is this package, so I'm wondering if it is still maintained and worked on? Will v3 happen?

If not we'll probably try to roll out a Piwik/SEO package with our implementations, maybe we could also merge some code from here after refactoring it a bit? Or maybe you still want to make v3 happen? We could also work on this together. Our only constraint is PHP 5.3 for now (yeah I know…).

ClemensSahs commented 9 years ago

@mnapoli The main concept of the V3 still exist. I have a separate version branch in my repository. This is current WorkInProgress but we implement all the things.

If your have any notes or improvements, your are welcome to join this progress.

v3 v3-wip

PHP5.3 is not longer supported by php.net. All my server run with php5.6 or HHVM and for the most server OS are php 5.4+ available. In our case we want to use Traits an some other nice stuff. ;)

clinttepe commented 9 years ago

We recently started using both Piwik and this script, so we'd love to see collaboration (and PHP5.4+ :-)! We use both for our own internal purposes of monitoring client sites, and also plan on embedding various elements into admin pages for clients who want direct access to this type of data. If either of you need testers, we'd be happy to help!

mnapoli commented 9 years ago

I have to say I'm not too enthusiastic about how that v3 for now:

and in general the code seems way more complicated that needed. Look for example at the Bing implementation in Piwik: it uses dependency injection for the logger (it should do the same for the HTTP adapter once it's not a static class anymore…), then it's a regex and that's it (please ignore the Piwik-specific stuff, the code is not perfect yet).

I think this library could be greatly simplified by relying on 3rd party libraries (and interfaces) and following simple patterns like dependency injection.

Following DRY is good as long as it doesn't make things more complicated. And when I see this class, I see too much DRY. Yes it's only 3 lines of code, but we have no idea what's going on…