search

eyecatchup / SEOstats

SEOstats is a powerful open source PHP library to request a bunch of SEO relevant metrics.
MIT License
1.46k stars 384 forks source link

Config in interface constants #98

Closed JacobDorman closed 8 years ago

JacobDorman commented 9 years ago

Is SEOStats configured by directly editing interface constants inside the vendor directory? eg, vendor/seostats/seostats/SEOstats/Config/ApiKeys.php for mozscape API keys

Maybe something like https://github.com/vlucas/phpdotenv would be a better approach.

ClemensSahs commented 9 years ago

Yes the current solution is crappie. Currently I refactor the architecture of SeoStats. The new solution give the ability to be more flexible und change the behavior over events.

So sorry for the current version 2.x we must hold this solution. But if you want help me with the 3.x branch we will faster to finish that work.

tholu commented 9 years ago

+1 for fixing this.

rootman commented 9 years ago

+1

ghost commented 9 years ago

+1

hughsaffar commented 9 years ago

+1

xarvel commented 8 years ago

+1

mhammerschmidt commented 8 years ago

Is there currently any workaround to set the API keys in case the vendor directory is not checked-in?

mhammerschmidt commented 8 years ago

We try to make a PR

Gemorroj commented 8 years ago

any news?

eyecatchup commented 8 years ago

Closed by merging @mhammerschmidt's PR (#131)