Open mateon1 opened 6 years ago
The infinite loop should be fixed in 39d55592e67f00d85ba737c7c3fed69022100340. Filenames that are invalid UTF-8 are hard to support with the current architecture as the front-end communicates with the core through JSON and the JSON has to be valid UTF-8. Support for files whose content uses a non-UTF-8 encoding is something that should be handled in the core.
Support for non-utf8 filenames would be possible if annoying, but is probably something xi-core should support eventually. It means paths are going to need to be sent in base64 or something. I'd welcome an issue in xi-core but I don't expect to get around to it in a hurry.
Better support for non-utf8 encodings is definitely important, and there's been some very preliminary groundwork in this direction in core. I also don't think there's a real issue up for that, so again file in xi-core if you like @mateon1 :)
See also google/xi-editor#796
How to reproduce:
20 ed 96 4f 56
(or escaped):" \xed\x96OV"
the file is a corrupt stack trace that contains some non-utf8 gibberish, but any binary file should work.Stdout/stderr:
The spam of Json-CRITICAL errors continues forever. The only solution is to kill xi-gtk.