eyelash / xi-gtk

a GTK front-end for the Xi editor
Apache License 2.0
355 stars 23 forks source link

Hide tabs when only single tab is open. #55

Closed LiHRaM closed 6 years ago

LiHRaM commented 6 years ago

To be consistent with other Gtk apps, such as the terminal or Gedit, etc. Also saves space in case only one is used.

eyelash commented 6 years ago

I originally considered this but then decided against it, so I guess it deserves some discussion. My original reasons were:

but I also see your point and hiding tabs seems to be the norm in GTK apps.

LiHRaM commented 6 years ago

That's fair! I think the main benefits of hiding the tabs when only one view is open is the clean look, and extra space. I'm sure that's an entirely subjective experience though. The draggability is a good point, and I suppose the only way to resolve that while keeping hidden tabs as default would be to give the user the option of toggling tabs visibility for dragging them across. That may not be the most feasible option.

My issue with the current design is mostly the fact that initially, the tab fills the entire width of the window. I suppose an alternative design could be to simply limit the tab width?

eyelash commented 6 years ago

One more reason to keep the tabs visible: I plan to put a command palette in the header bar (centered, similar to the URL bar in epiphany), so the tab is the only place where you see the name of the file you are currently working on.

My issue with the current design is mostly the fact that initially, the tab fills the entire width of the window. I suppose an alternative design could be to simply limit the tab width?

We could set a maximum width for tabs but honestly I like the fact that the tab fills the entire width. It makes the whole interface balanced and symmetric.

LiHRaM commented 6 years ago

We could set a maximum width for tabs but honestly I like the fact that the tab fills the entire width. It makes the whole interface balanced and symmetric.

That's fair enough. As you are the owner of the project, I respect your final say. I'll just close this. Maybe it can become an option at some point.