search

eyeonus / Trade-Dangerous

Mozilla Public License 2.0
97 stars 31 forks source link

EDDB certificate issue? #101

Closed trimble closed 2 years ago

trimble commented 2 years ago

Browsing manually to https://eddb.io/archive/v6/systems_populated.jsonl yields data...but trade import throws a certificate error:

C:\tradedangerous>trade import -P eddblink -O fallback
NOTE: Checking for update to 'systems_populated.jsonl'.
WARNING: Problem with download (fallback enabled):
URL: https://eddb.io/archive/v6/systems_populated.jsonl
Error: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1129)>
NOTE: Checking for update to 'stations.jsonl'.
WARNING: Problem with download (fallback enabled):
URL: https://eddb.io/archive/v6/stations.jsonl
Error: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1129)>
NOTE: Checking for update to 'commodities.json'.
WARNING: Problem with download (fallback enabled):
URL: https://eddb.io/archive/v6/commodities.json
Error: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1129)>
NOTE: Checking for update to 'listings.csv'.
WARNING: Problem with download (fallback enabled):
URL: https://eddb.io/archive/v6/listings.csv
Error: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1129)>
NOTE: Import completed.
eyeonus commented 2 years ago

Unable to reproduce.

Certificate expiration is an HTTP thing, there's nothing wrong with the code.

TD uses urllib.requests to download the files, you may want to check documentation regarding certificates for that module if the problem does not clear up on its own when the EDDB certificate is updated to one that is not expired.