search

eyeonus / Trade-Dangerous

Mozilla Public License 2.0
96 stars 31 forks source link

When I run the command "trade.py import -P eddblink -O all", I get error messages ! #142

Closed nepomuk16321 closed 2 months ago

nepomuk16321 commented 2 months ago

Hello, as requested, I have opened this issue. You can read about the start of my problems here: https://forums.frontier.co.uk/threads/trade-dangerous-est-2015-power-users-highly-configurable-trade-optimizer.441509/post-10361659 ... The last action to find the problem was to run "locale_test.zip". The files were requested and downloaded. image Ok, what can I do next ?

eyeonus commented 2 months ago

Thank you.

Your problem is indeed caused by having a non-English locale as default. (I couldn't test myself because I have en_US as my default locale.)

Now that I know that, I can implement the fix.

I've pushed a change to the test branch, would you please download it (using the same link I gave you already) and run python .\trade.py import -P eddblink -www?

You should get a message like the following: 

#Command line was: ['./trade.py', 'import', '-P', 'eddblink', '-www']
#Using "en_US.UTF-8" locale for parsing modified timestamps. Please include this information in any error reports.
NOTE: Checking for update to 'System.csv'.

If you do successfully get Using ... locale ..., let me know it was a success. (NOTE: The exact locale may not match because the plugin finds the first locale installed on your machine that is English and UTF-8 and uses that.)

@kfsone You have a Mac, can you test this too?

nepomuk16321 commented 2 months ago

So, downloaded the second test file, unpacked it and executed the above command. Result: image The error message is slightly different from the one you expected. I hope this helps you anyway. And by the way, thank you for taking the trouble to customize TD for me (hopefully not only). Thank you very much !

eyeonus commented 2 months ago

Would you run this and give me the output, please?

locales.zip

nepomuk16321 commented 2 months ago

... of course ... image ... and maybe this screenshot from Windows will also help image

eyeonus commented 2 months ago

I thought as much. Okay, one more time, download the new version, run python .\trade.py import -P eddblink -www, let me know what happens. Hopefully I've got it all cleared up now and we can push this to the main branch.

kfsone commented 2 months ago

I'll not be able to test on the mac (which botched an update and is currently doing a recovery) until tomorrow.

nepomuk16321 commented 2 months ago

Ok, I downloaded this version again from the link in the forum. I hope that was correct. And I have just executed the command. I can't take a screenshot because there is a lot of data running across the screen. Let's see what the result is. Ok, a screenshot was possible after all (the data continues to run through): image ...

eyeonus commented 2 months ago

Fixed in v11.1.2

Thanks @nepomuk16321 for you assistance.

nepomuk16321 commented 2 months ago

Sorry, I still owe you the final report: image I hope it is as expected. Thank you very much !