search

eyeonus / Trade-Dangerous

Mozilla Public License 2.0
97 stars 31 forks source link

Void opal import issue #84

Closed hahn-kev closed 3 years ago

hahn-kev commented 3 years ago

I've just started using the tool. I installed it using pip but when I try to import price data from EDMC I get this error:

tmp\batch.prices:96 ERROR Unrecognized item name: "VOID OPAL"

I worked around it by removing those lines from the import files, but this seems like a bigger issue.

Edit: looks like in the csv they're called "void opals" it looks like there may be a naming missmatch between EDMC and TD.

eyeonus commented 3 years ago

That code is there to prevent items that are not in the commodity table of the database from being added to the market table, as doing so causes issues.

TD names the commodities the same as they are named on EDDB.io, any discrepencies between TD and the import file should be handled by including the item in the appropriate section of 'corrections.py': https://github.com/eyeonus/Trade-Dangerous/blob/8a0c3c1ad93784c1c11425ab16f890baba6e017f/tradedangerous/corrections.py#L25-L34