search

eyeonus / TradeDangerous-listener

An EDDN listener, designed to work in conjunction with the EDDBlink plugin for Trade Dangerous.
GNU Lesser General Public License v3.0
4 stars 3 forks source link

Unicode problem fixed on Windows 10 x64 JP loc #23

Closed Kaens closed 2 years ago

Kaens commented 2 years ago

Before: https://lithi.io/file/kq5Y.png (note how the updates never happen, but the rejections do) After: https://lithi.io/file/FSDL.png (everything seems to work fine)

Tromador commented 2 years ago

I am unable to view your screenshots - 

Secure Connection Failed

An error occurred during a connection to lithi.io. SSL received a record that exceeded the maximum permissible length.

Error code: SSL_ERROR_RX_RECORD_TOO_LONG

    The page you are trying to view cannot be shown because the authenticity of the received data could not be verified.
    Please contact the web site owners to inform them of this problem.
Kaens commented 2 years ago

Huh. That's super strange. Okay, now that the UI allows me to upload from clipboard, I'll just do it this way: Before image After image

Tromador commented 2 years ago

I see where you are coming from. It will be a specific issue for any systems using a non-latin character set, your fix should cover them all, so we should probably adopt it (though I'll leave eyeonus to make the final decision).

I should say we normally recommend users to not user the listener, but to use Trade Dangerous which will connect to the server I run.

eyeonus commented 2 years ago

I looked at it, and I see nothing wrong, I just want to make sure there aren't any other places in the code where that should also be done before I merge.

On Thu, Jul 7, 2022, 15:37 Stefan Morrell @.***> wrote:

I see where you are coming from. It will be a specific issue for any systems using a non-latin character set, your fix should cover them all, so we should probably adopt it (though I'll leave eyeonus to make the final decision).

I should say we normally recommend users to not user the listener, but to use Trade Dangerous https://forums.frontier.co.uk/threads/trade-dangerous-est-2015-power-users-highly-configurable-trade-optimizer.441509/ which will connect to the server I run.

— Reply to this email directly, view it on GitHub https://github.com/eyeonus/EDDBlink-listener/pull/23#issuecomment-1178255110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANHHYAECD2WM7QL6JTNLFTVS5EYXANCNFSM526SE34A . You are receiving this because you are subscribed to this thread.Message ID: @.***>