search

eyeseast / geocode-sqlite

Geocode rows in a SQLite database table
Apache License 2.0
231 stars 6 forks source link

Pass bbox option to geocoders #17

Closed eyeseast closed 3 years ago

eyeseast commented 3 years ago

In cases where a geography is unclear, would be good to constrain results in geocoders that support it.

eyeseast commented 3 years ago

One wrinkle in this: Not all geocoders support it, and it's passed in as an argument to geocode(), not __init__, so it needs to be passed to the CLI callback and then maybe discarded.

eyeseast commented 3 years ago

Maybe an options or kwargs dictionary gets passed into the context object so we can use it later. Probably the most straightforward way to handle options like this.

eyeseast commented 3 years ago

Looking at the options available for Mapbox, for example, it would be worth being able to pass in things like country or proximity to bias results, especially with messier datasets.

eyeseast commented 3 years ago

Fixed in #18