eyeseast / geocode-sqlite

Geocode rows in a SQLite database table
Apache License 2.0
231 stars 6 forks source link

Use rate limiting by default? #3

Closed eyeseast closed 4 years ago

eyeseast commented 4 years ago

It's generally bad practice to throw a few hundred geocoding requests at a free service. Given that, is it worth setting a default delay of one second, and let people explicitly turn it off if needed?

eyeseast commented 4 years ago

Nice thing about Geopy's built-in rate limiting is that it handles errors and retries out of the box: https://geopy.readthedocs.io/en/latest/#geopy.extra.rate_limiter.RateLimiter That's worth the price of admission on its own.

eyeseast commented 4 years ago

Yes, as of just now.