jgroom33
commented
5 years ago @shrikster can you resolve the conflicts and resubmit?
Closed shrikster closed 5 years ago
jgroom33
commented
5 years ago @shrikster can you resolve the conflicts and resubmit?
Hi this PR solvee Issue #95 , Add support for using the strest test filename as a parameter in the request . I was a little bit more complicated than stated in the issue , due to the fact that the testObject.relativepath is not the file name , it's just the path to the file . 1.I have added fileName property on parse file object at yaml-parse.ts, and updated the schema . 2.Passes the file name to the computeRequestObject that uses the common practice of regex replacing the Filname() string with the fileName 3.updated the readme I have 2 Notes 1.I am removing the strest suffix from the file name - see the computeRequestObject function . 2.we need to consider using nodejs path.parse(filePath) to get all the file parts .. (folder / root )
see this line const {name:fileName} = path.parse(filePath);