Closed ghost closed 3 months ago
Just throwing that here, I didn't check anything. But the goal of pywal16 is to have a wider range of colors, the backgroundColor in the original pywal is likely closer to color8 of pywal16 rather than color0. I'd say the solution for you if you want a lighter background color is to tap in color8 instead of backgroundColor? Otherwise it would simply turn the issue around for people that want a darker background color I think?
Although I get the issue of not being very iso with pywal, but I'm not sure that is the goal of the project.
@guillaumeboehm
This how color 8 looks like
Here is the template i use as well in case it's needed
@define-color foreground {foreground};
@define-color background {background};
@define-color cursor {cursor};
@define-color color0 {color0};
@define-color color1 {color1};
@define-color color2 {color2};
@define-color color3 {color3};
@define-color color4 {color4};
@define-color color5 {color5};
@define-color color6 {color6};
@define-color color7 {color7};
@define-color color8 {color8};
@define-color color9 {color9};
@define-color color10 {color10};
@define-color color11 {color11};
@define-color color12 {color12};
@define-color color13 {color13};
@define-color color14 {color14};
@define-color color15 {color15};
Maybe color generation could need some rework, but seeing that a partial or maybe full rewrite of the program is probably on the way. I'd say it can wait until then.
yep i have noticed that too. but if i change engine to haishoku then it works a bit nice and doesn't tilt towards dark black.
@eylles is the background dark color is intentional?
hmmm i barely changed anything about how colors are generated and adjusted, tho i think when sonjiku made the original pr he did make color[0] quite darker.
welp i guess it happened either here: https://github.com/eylles/pywal16/commit/e504c55e70fca7fff4a98bc0c6e460832d9d2662 or here: https://github.com/eylles/pywal16/commit/42efe31c95cad31158a40ab588fc8c198fbb3bc4
hmmm interesting, the only change is with the wal backend that is now generating a darker bg color.
with my current wallapaper:
these are the values i get
pywal16 | |
---|---|
wal bg: | #050509 |
colorthief bg: | #08090f |
pywal | |
---|---|
wal bg: | #11101d |
colorthief bg: | #08090f |
tagging @BEST8OY since he also reported this.
welp i'll simply modify the wal backend to output a lighter color before it gets darkened by the generic adjust function, unless someone does want to also have the darker bg from wal as an option.
looking forward for the fix commit.
and for general info ig that everyone knows but pywal
is now archived..... so now pywal-16
is going to be the standard replacement ig.
hmmm i barely changed anything about how colors are generated and adjusted, tho i think when sonjiku made the original pr he did make color[0] quite darker. tagging @BEST8OY since he also reported this.
still not the way I expect it to be!
Would you mind sharing your wallpaper so i can use it to check the color values first hand?
Would you mind sharing your wallpaper so i can use it to check the color values first hand?
I don't have the wallpaper used by @BEST8OY but the wallpaper i used for above is
in the above preview you can see that colors of nautilus are quite darker (better than before but still a bit darker)
using 3.5.3
Would you mind sharing your wallpaper so i can use it to check the color values first hand?
Thanks, will check and try to figure out where in the code the color 0 shades differ
This is the image that should give a brownish background but it is giving a pitch black one.
I generate pywal colors for heroic and i use color0
-> backgroud
as the background for the heroic launcher
thanks, will have to use the 3 images to check exactly what is going on, haven't had much time to check and fix this since last friday catched a sprained ankle and got 2 things that i need to tend before going back to this.
@eylles is this done for only wal
as haishoku
engine bg is fine and looking nice.
so about work on this i got a test diff with 3 prints, first is the raw output from imagemagick with garbage values and all, second is the dict of colors before the adjust function and third is after the adjust function.
diff --git a/pywal/backends/wal.py b/pywal/backends/wal.py
index 77f51c7..ea9fe52 100644
--- a/pywal/backends/wal.py
+++ b/pywal/backends/wal.py
@@ -20,6 +20,7 @@ def imagemagick(color_count, img, magick_command):
try:
output = subprocess.check_output([*magick_command, img, *flags],
stderr=subprocess.STDOUT).splitlines()
+ print(output)
except subprocess.CalledProcessError as Err:
logging.error("Imagemagick error: %s", Err)
logging.error(
@@ -79,4 +80,7 @@ def get(img, light=False, cols16=False):
garbage = "# Image"
if garbage in colors:
colors.remove(garbage)
- return adjust(colors, light, cols16)
+ print(colors)
+ result = adjust(colors, light, cols16)
+ print(result)
+ return result
now i just need to apply something similar to legacy pywal, got a clone of the og repo and the latest release tag checked, will return in a while with the diff and some tests to try and gather where exactly do the colors differ and perhaps why and for how much.
@eylles is this done for only
wal
ashaishoku
engine bg is fine and looking nice.
you mean in pywal16 3.5.3 or in pywal 3.3.0 ? cuz previos versions of pywal16 would produce a darker bg color right now the generic adjust function checks if the first element of the color[0] (bg) is "0" and if it isn't it will darken the color by 40%
that 40% was the adjust from legacy pywal to the bg color of the wal backend:
however not every backend takes nicely to using the new 40% darken of the background as many backends such as: schemer2: https://github.com/eylles/pywal16/blob/984c7b640ea2336df351c87f744104e51ca32970/pywal/backends/schemer2.py#L24 haishoku: https://github.com/eylles/pywal16/blob/984c7b640ea2336df351c87f744104e51ca32970/pywal/backends/haishoku.py#L25-L31 colorz: https://github.com/eylles/pywal16/blob/984c7b640ea2336df351c87f744104e51ca32970/pywal/backends/colorz.py#L31
expect the old adjust function that would darken their background by 80% https://github.com/eylles/pywal16/blob/984c7b640ea2336df351c87f744104e51ca32970/pywal/colors.py#L55-L73
for colorthief i added a pre-adjust to try and match the old adjust that it had and darken the bg color by 80% colorthief current: https://github.com/eylles/pywal16/blob/a5ebec00befb99e6c3bd84cce9f95005e4e3dbf3/pywal/backends/colorthief.py#L40-L48
colorthief legacy: https://github.com/eylles/pywal16/blob/984c7b640ea2336df351c87f744104e51ca32970/pywal/backends/colorthief.py#L39-L58
so my problem right now is not so easy as i have to add a way for backends to do see the 80% darkening of the bg but wal only get the bg darken by 40% and also figure out why even now it does produce a darker bg color with some images.
i am currently having 3.5.3
and on wal
engine it is still a bit dark.
been testing image by image also checking with a pair of my own, been cobbling a huge detailed post with tables, i got a final for CS61C (well, the cs61c variant at my university) tomorrow so i may be able to post the results of testing on wednesday.
been testing image by image also checking with a pair of my own, been cobbling a huge detailed post with tables, i got a final for CS61C (well, the cs61c variant at my university) tomorrow so i may be able to post the results of testing on wednesday.
Just in case, I'm getting this with wal backend on arch with latest updates.
[best8oy@DIAMOND ~D]$ wal -i RE4wqI5.jpeg
[I] image: Using image RE4wqI5.jpeg.
[I] colors: Generating a colorscheme.
[I] colors: Using wal backend.
Traceback (most recent call last):
File "/usr/bin/wal", line 33, in <module>
sys.exit(load_entry_point('pywal16==3.5.3', 'console_scripts', 'wal')())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/pywal/__main__.py", line 244, in main
parse_args(parser)
File "/usr/lib/python3.12/site-packages/pywal/__main__.py", line 184, in parse_args
colors_plain = colors.get(image_file, args.l, args.cols16, args.backend,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/pywal/colors.py", line 213, in get
colors = getattr(backend, "get")(img, light, cols16)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/pywal/backends/wal.py", line 77, in get
colors = gen_colors(img)
^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/pywal/backends/wal.py", line 64, in gen_colors
return [re.search("#.{6}", str(col)).group(0) for col in raw_colors[1:]]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'
Thanks @BEST8OY please follow the instructions on https://github.com/eylles/pywal16/issues/48#issuecomment-2135468384 and report back there.
okay, so pywal16 and pywal legacy both with the same debug print.
pywal: https://github.com/eylles/pywal/tree/test-cols
pywal16: https://github.com/eylles/pywal16/tree/test-cols
so to compare apples to apples both debug prints are a commit after the release that is currently on pypi. (not really right now as the pywal16 branch was based on 3.5.3)
so let's see, first wiht my current wallaper
pywal:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (51.2023,18.5603,22.5564) #331317 srgb(20.0793%,7.27855%,8.84565%)', b'1,0: (23.7743,23.214,34.0195) #181722 srgb(9.32326%,9.10353%,13.341%)', b'2,0: (45.9922,27.4008,37.5992) #2E1B26 srgb(18.0362%,10.7454%,14.7448%)', b'3,0: (47.3541,38.6381,51.821) #2F2734 srgb(18.5702%,15.1522%,20.322%)', b'4,0: (89.5019,29.8521,32.6109) #5A1E21 srgb(35.0988%,11.7067%,12.7886%)', b'5,0: (77.1556,40.5409,49.9222) #4D2932 srgb(30.2571%,15.8984%,19.5773%)', b'6,0: (31.6576,43.0233,66.2451) #202B42 srgb(12.4147%,16.8719%,25.9785%)', b'7,0: (52.5214,50.9689,73.358) #353349 srgb(20.5966%,19.9878%,28.7678%)', b'8,0: (78.1673,54.93,71.358) #4E3747 srgb(30.6538%,21.5412%,27.9835%)', b'9,0: (71.8288,68.1751,81.8249) #484452 srgb(28.1682%,26.7353%,32.0882%)', b'10,0: (89.9883,78.5953,95.4436) #5A4F5F srgb(35.2895%,30.8217%,37.4289%)', b'11,0: (152.973,44.7043,43.572) #992D2C srgb(59.9893%,17.5311%,17.0871%)', b'12,0: (158.782,106.529,104.191) #9F6B68 srgb(62.2675%,41.7762%,40.8591%)', b'13,0: (223.907,71.1167,65.8249) #E04742 srgb(87.8065%,27.8889%,25.8137%)', b'14,0: (156.031,124.638,127.794) #9C7D80 srgb(61.1887%,48.8777%,50.1152%)', b'15,0: (188.21,157.887,161.938) #BC9EA2 srgb(73.8079%,61.9165%,63.505%)' ]
pre-adjust:
[
#331317 ,
#4E3747 ,
#484452 ,
#5A4F5F ,
#992D2C ,
#9F6B68 ,
#E04742 ,
#9C7D80 ,
#BC9EA2 ,
#4E3747 ,
#484452 ,
#5A4F5F ,
#992D2C ,
#9F6B68 ,
#E04742 ,
#9C7D80
]
post-adjust:
[
#1e0b0d ,
#4E3747 ,
#484452 ,
#5A4F5F ,
#992D2C ,
#9F6B68 ,
#E04742 ,
#c5b5b7 ,
#897e80 ,
#4E3747 ,
#484452 ,
#5A4F5F ,
#992D2C ,
#9F6B68 ,
#E04742 ,
#c5b5b7
]
pywal16:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (51.2023,18.5603,22.5564) #331317 srgb(20.0793%,7.27855%,8.84565%)', b'1,0: (23.7743,23.214,34.0195) #181722 srgb(9.32326%,9.10353%,13.341%)', b'2,0: (45.9922,27.4008,37.5992) #2E1B26 srgb(18.0362%,10.7454%,14.7448%)', b'3,0: (47.3541,38.6381,51.821) #2F2734 srgb(18.5702%,15.1522%,20.322%)', b'4,0: (89.5019,29.8521,32.6109) #5A1E21 srgb(35.0988%,11.7067%,12.7886%)', b'5,0: (77.1556,40.5409,49.9222) #4D2932 srgb(30.2571%,15.8984%,19.5773%)', b'6,0: (31.6576,43.0233,66.2451) #202B42 srgb(12.4147%,16.8719%,25.9785%)', b'7,0: (52.5214,50.9689,73.358) #353349 srgb(20.5966%,19.9878%,28.7678%)', b'8,0: (78.1673,54.93,71.358) #4E3747 srgb(30.6538%,21.5412%,27.9835%)', b'9,0: (71.8288,68.1751,81.8249) #484452 srgb(28.1682%,26.7353%,32.0882%)', b'10,0: (89.9883,78.5953,95.4436) #5A4F5F srgb(35.2895%,30.8217%,37.4289%)', b'11,0: (152.973,44.7043,43.572) #992D2C srgb(59.9893%,17.5311%,17.0871%)', b'12,0: (158.782,106.529,104.191) #9F6B68 srgb(62.2675%,41.7762%,40.8591%)', b'13,0: (223.907,71.1167,65.8249) #E04742 srgb(87.8065%,27.8889%,25.8137%)', b'14,0: (156.031,124.638,127.794) #9C7D80 srgb(61.1887%,48.8777%,50.1152%)', b'15,0: (188.21,157.887,161.938) #BC9EA2 srgb(73.8079%,61.9165%,63.505%)' ]
pre-adjust:
[
#331317 ,
#181722 ,
#2E1B26 ,
#2F2734 ,
#5A1E21 ,
#4D2932 ,
#202B42 ,
#353349 ,
#4E3747 ,
#484452 ,
#5A4F5F ,
#992D2C ,
#9F6B68 ,
#E04742 ,
#9C7D80 ,
#BC9EA2
]
post-adjust:
[
#1e0b0d ,
#4E3747 ,
#484452 ,
#5A4F5F ,
#992D2C ,
#9F6B68 ,
#E04742 ,
#c6c2c2 ,
#564849 ,
#4E3747 ,
#484452 ,
#5A4F5F ,
#992D2C ,
#9F6B68 ,
#E04742 ,
#c6c2c2
]
the wallaper i was using before
pywal
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (28.6226,28.1673,49.3969) #1D1C31 srgb(11.2245%,11.046%,19.3713%)', b'1,0: (83.4903,50.2412,59.7588) #53323C srgb(32.7413%,19.7024%,23.4348%)', b'2,0: (37.0272,48.7743,80.5603) #253151 srgb(14.5205%,19.1272%,31.5923%)', b'3,0: (45.2257,71.7315,110.471) #2D486E srgb(17.7356%,28.13%,43.3219%)', b'4,0: (83.4942,80.8677,105.747) #53516A srgb(32.7428%,31.7128%,41.4694%)', b'5,0: (167.482,72.6498,70.4241) #A74946 srgb(65.6794%,28.4901%,27.6173%)', b'6,0: (51.0895,92.5097,141.066) #335D8D srgb(20.0351%,36.2783%,55.3201%)', b'7,0: (91.5992,108.782,146.113) #5C6D92 srgb(35.9213%,42.6596%,57.2992%)', b'8,0: (163.16,118.72,141.51) #A3778E srgb(63.9841%,46.5568%,55.494%)', b'9,0: (102.132,144.101,175.595) #6690B0 srgb(40.0519%,56.5103%,68.8609%)', b'10,0: (108.895,179.665,210.451) #6DB4D2 srgb(42.7039%,70.457%,82.5299%)', b'11,0: (153.549,156.187,172.926) #9A9CAD srgb(60.2152%,61.2497%,67.8141%)', b'12,0: (218.148,170.374,178.245) #DAAAB2 srgb(85.5482%,66.8132%,69.9001%)', b'13,0: (154.673,180.809,202.156) #9BB5CA srgb(60.6561%,70.9056%,79.2767%)', b'14,0: (162.455,210.825,225.981) #A2D3E2 srgb(63.7079%,82.6764%,88.6198%)', b'15,0: (230.004,229.86,233.755) #E6E6EA srgb(90.1976%,90.1411%,91.6686%)' ]
pre-adjust:
[
#1D1C31 ,
#A3778E ,
#6690B0 ,
#6DB4D2 ,
#9A9CAD ,
#DAAAB2 ,
#9BB5CA ,
#A2D3E2 ,
#E6E6EA ,
#A3778E ,
#6690B0 ,
#6DB4D2 ,
#9A9CAD ,
#DAAAB2 ,
#9BB5CA ,
#A2D3E2
]
post-adjust:
[
#11101d ,
#A3778E ,
#6690B0 ,
#6DB4D2 ,
#9A9CAD ,
#DAAAB2 ,
#9BB5CA ,
#c8e0e8 ,
#8c9ca2 ,
#A3778E ,
#6690B0 ,
#6DB4D2 ,
#9A9CAD ,
#DAAAB2 ,
#9BB5CA ,
#c8e0e8
]
pywal16:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (28.6226,28.1673,49.3969) #1D1C31 srgb(11.2245%,11.046%,19.3713%)', b'1,0: (83.4903,50.2412,59.7588) #53323C srgb(32.7413%,19.7024%,23.4348%)', b'2,0: (37.0272,48.7743,80.5603) #253151 srgb(14.5205%,19.1272%,31.5923%)', b'3,0: (45.2257,71.7315,110.471) #2D486E srgb(17.7356%,28.13%,43.3219%)', b'4,0: (83.4942,80.8677,105.747) #53516A srgb(32.7428%,31.7128%,41.4694%)', b'5,0: (167.482,72.6498,70.4241) #A74946 srgb(65.6794%,28.4901%,27.6173%)', b'6,0: (51.0895,92.5097,141.066) #335D8D srgb(20.0351%,36.2783%,55.3201%)', b'7,0: (91.5992,108.782,146.113) #5C6D92 srgb(35.9213%,42.6596%,57.2992%)', b'8,0: (163.16,118.72,141.51) #A3778E srgb(63.9841%,46.5568%,55.494%)', b'9,0: (102.132,144.101,175.595) #6690B0 srgb(40.0519%,56.5103%,68.8609%)', b'10,0: (108.895,179.665,210.451) #6DB4D2 srgb(42.7039%,70.457%,82.5299%)', b'11,0: (153.549,156.187,172.926) #9A9CAD srgb(60.2152%,61.2497%,67.8141%)', b'12,0: (218.148,170.374,178.245) #DAAAB2 srgb(85.5482%,66.8132%,69.9001%)', b'13,0: (154.673,180.809,202.156) #9BB5CA srgb(60.6561%,70.9056%,79.2767%)', b'14,0: (162.455,210.825,225.981) #A2D3E2 srgb(63.7079%,82.6764%,88.6198%)', b'15,0: (230.004,229.86,233.755) #E6E6EA srgb(90.1976%,90.1411%,91.6686%)' ]
pre-adjust:
[
#1D1C31 ,
#53323C ,
#253151 ,
#2D486E ,
#53516A ,
#A74946 ,
#335D8D ,
#5C6D92 ,
#A3778E ,
#6690B0 ,
#6DB4D2 ,
#9A9CAD ,
#DAAAB2 ,
#9BB5CA ,
#A2D3E2 ,
#E6E6EA
]
post-adjust:
[
#11101d ,
#A3778E ,
#6690B0 ,
#6DB4D2 ,
#9A9CAD ,
#DAAAB2 ,
#9BB5CA ,
#c3c3c6 ,
#4c4b55 ,
#A3778E ,
#6690B0 ,
#6DB4D2 ,
#9A9CAD ,
#DAAAB2 ,
#9BB5CA ,
#c3c3c6
]
best8boy's wallpaper
pywal:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (29.7938,42.8794,41.0778) #1E2B29 srgb(11.6838%,16.8154%,16.1089%)', b'1,0: (39.0856,54.323,44.0895) #27362C srgb(15.3277%,21.3031%,17.29%)', b'2,0: (52.4708,76.8016,47.7821) #344D30 srgb(20.5768%,30.1183%,18.7381%)', b'3,0: (60.4436,99.2568,51.3385) #3C6333 srgb(23.7034%,38.9242%,20.1328%)', b'4,0: (68.7977,89.1673,48.9027) #455931 srgb(26.9795%,34.9676%,19.1775%)', b'5,0: (78.8599,109.646,51.2062) #4F6E33 srgb(30.9255%,42.9984%,20.0809%)', b'6,0: (100.58,120.195,49.3385) #657831 srgb(39.443%,47.1351%,19.3484%)', b'7,0: (59.4514,87.249,65.1907) #3B5741 srgb(23.3143%,34.2153%,25.565%)', b'8,0: (88.3191,113.416,68.5331) #587145 srgb(34.6349%,44.477%,26.8757%)', b'9,0: (98.5875,139.311,53.3619) #638B35 srgb(38.6618%,54.6319%,20.9262%)', b'10,0: (109.661,141.696,53.9377) #6E8E36 srgb(43.0045%,55.5673%,21.1521%)', b'11,0: (112.339,146.634,69.6342) #709346 srgb(44.0543%,57.5036%,27.3075%)', b'12,0: (141.416,165.984,53.2646) #8DA635 srgb(55.4574%,65.0919%,20.8881%)', b'13,0: (146.074,172.588,77.6459) #92AD4E srgb(57.2839%,67.6814%,30.4494%)', b'14,0: (179.074,203.265,88.3502) #B3CB58 srgb(70.2251%,79.7116%,34.6471%)', b'15,0: (195.218,203.381,133.416) #C3CB85 srgb(76.556%,79.7574%,52.3201%)' ]
pre-adjust:
[
#1E2B29 ,
#587145 ,
#638B35 ,
#6E8E36 ,
#709346 ,
#8DA635 ,
#92AD4E ,
#B3CB58 ,
#C3CB85 ,
#587145 ,
#638B35 ,
#6E8E36 ,
#709346 ,
#8DA635 ,
#92AD4E ,
#B3CB58
]
post-adjust:
[
#121918 ,
#587145 ,
#638B35 ,
#6E8E36 ,
#709346 ,
#8DA635 ,
#92AD4E ,
#d0dca3 ,
#919a72 ,
#587145 ,
#638B35 ,
#6E8E36 ,
#709346 ,
#8DA635 ,
#92AD4E ,
#d0dca3
]
pywal16:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (29.7938,42.8794,41.0778) #1E2B29 srgb(11.6838%,16.8154%,16.1089%)', b'1,0: (39.0856,54.323,44.0895) #27362C srgb(15.3277%,21.3031%,17.29%)', b'2,0: (52.4708,76.8016,47.7821) #344D30 srgb(20.5768%,30.1183%,18.7381%)', b'3,0: (60.4436,99.2568,51.3385) #3C6333 srgb(23.7034%,38.9242%,20.1328%)', b'4,0: (68.7977,89.1673,48.9027) #455931 srgb(26.9795%,34.9676%,19.1775%)', b'5,0: (78.8599,109.646,51.2062) #4F6E33 srgb(30.9255%,42.9984%,20.0809%)', b'6,0: (100.58,120.195,49.3385) #657831 srgb(39.443%,47.1351%,19.3484%)', b'7,0: (59.4514,87.249,65.1907) #3B5741 srgb(23.3143%,34.2153%,25.565%)', b'8,0: (88.3191,113.416,68.5331) #587145 srgb(34.6349%,44.477%,26.8757%)', b'9,0: (98.5875,139.311,53.3619) #638B35 srgb(38.6618%,54.6319%,20.9262%)', b'10,0: (109.661,141.696,53.9377) #6E8E36 srgb(43.0045%,55.5673%,21.1521%)', b'11,0: (112.339,146.634,69.6342) #709346 srgb(44.0543%,57.5036%,27.3075%)', b'12,0: (141.416,165.984,53.2646) #8DA635 srgb(55.4574%,65.0919%,20.8881%)', b'13,0: (146.074,172.588,77.6459) #92AD4E srgb(57.2839%,67.6814%,30.4494%)', b'14,0: (179.074,203.265,88.3502) #B3CB58 srgb(70.2251%,79.7116%,34.6471%)', b'15,0: (195.218,203.381,133.416) #C3CB85 srgb(76.556%,79.7574%,52.3201%)' ]
pre-adjust:
[
#1E2B29 ,
#27362C ,
#344D30 ,
#3C6333 ,
#455931 ,
#4F6E33 ,
#657831 ,
#3B5741 ,
#587145 ,
#638B35 ,
#6E8E36 ,
#709346 ,
#8DA635 ,
#92AD4E ,
#B3CB58 ,
#C3CB85
]
post-adjust:
[
#121918 ,
#587145 ,
#638B35 ,
#6E8E36 ,
#709346 ,
#8DA635 ,
#92AD4E ,
#c3c5c5 ,
#4d5251 ,
#587145 ,
#638B35 ,
#6E8E36 ,
#709346 ,
#8DA635 ,
#92AD4E ,
#c3c5c5
]
as for niksignh710's images i got them as pngs both are huge, the leaves one is 7.6MB while the other is 27MB
niksignh710's leaves wallpaper
pywal:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (31.4864,38.4786,30.8794) #1F261F srgb(12.3476%,15.0896%,12.1096%)', b'1,0: (34.5837,45.5992,35.3502) #232E23 srgb(13.5622%,17.882%,13.8628%)', b'2,0: (46.7471,78.9533,47.0078) #2F4F2F srgb(18.3322%,30.9621%,18.4344%)', b'3,0: (57.4553,98.8171,53.2412) #396335 srgb(22.5315%,38.7518%,20.8789%)', b'4,0: (69.4553,90.7821,54.9416) #455B37 srgb(27.2374%,35.6008%,21.5457%)', b'5,0: (71.0156,108.167,58.2179) #476C3A srgb(27.8492%,42.4186%,22.8305%)', b'6,0: (60.7198,94.0739,65.8171) #3D5E42 srgb(23.8117%,36.8917%,25.8106%)', b'7,0: (79.7938,114.202,73.393) #507249 srgb(31.2917%,44.7852%,28.7816%)', b'8,0: (93.7198,117.152,81.07) #5E7551 srgb(36.7529%,45.9419%,31.7922%)', b'9,0: (140.833,119.992,72.2335) #8D7848 srgb(55.2285%,47.0558%,28.3268%)', b'10,0: (90.2724,131.125,60.2996) #5A833C srgb(35.4009%,51.4214%,23.6469%)', b'11,0: (106.475,137.642,86.5564) #6A8A57 srgb(41.7548%,53.9773%,33.9437%)', b'12,0: (110.195,140.638,95.9611) #6E8D60 srgb(43.2136%,55.1522%,37.6318%)', b'13,0: (142.607,163.447,111.984) #8FA370 srgb(55.9243%,64.097%,43.9155%)', b'14,0: (189.553,179.938,116.809) #BEB475 srgb(74.3343%,70.5638%,45.8076%)', b'15,0: (175.093,187.751,137.782) #AFBC8A srgb(68.6641%,73.6278%,54.0322%)' ]
pre-adjust:
[
#1F261F ,
#5E7551 ,
#8D7848 ,
#5A833C ,
#6A8A57 ,
#6E8D60 ,
#8FA370 ,
#BEB475 ,
#AFBC8A ,
#5E7551 ,
#8D7848 ,
#5A833C ,
#6A8A57 ,
#6E8D60 ,
#8FA370 ,
#BEB475
]
post-adjust:
[
#121612 ,
#5E7551 ,
#8D7848 ,
#5A833C ,
#6A8A57 ,
#6E8D60 ,
#8FA370 ,
#d6d1b1 ,
#95927b ,
#5E7551 ,
#8D7848 ,
#5A833C ,
#6A8A57 ,
#6E8D60 ,
#8FA370 ,
#d6d1b1
]
pywal16:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (31.4864,38.4786,30.8794) #1F261F srgb(12.3476%,15.0896%,12.1096%)', b'1,0: (34.5837,45.5992,35.3502) #232E23 srgb(13.5622%,17.882%,13.8628%)', b'2,0: (46.7471,78.9533,47.0078) #2F4F2F srgb(18.3322%,30.9621%,18.4344%)', b'3,0: (57.4553,98.8171,53.2412) #396335 srgb(22.5315%,38.7518%,20.8789%)', b'4,0: (69.4553,90.7821,54.9416) #455B37 srgb(27.2374%,35.6008%,21.5457%)', b'5,0: (71.0156,108.167,58.2179) #476C3A srgb(27.8492%,42.4186%,22.8305%)', b'6,0: (60.7198,94.0739,65.8171) #3D5E42 srgb(23.8117%,36.8917%,25.8106%)', b'7,0: (79.7938,114.202,73.393) #507249 srgb(31.2917%,44.7852%,28.7816%)', b'8,0: (93.7198,117.152,81.07) #5E7551 srgb(36.7529%,45.9419%,31.7922%)', b'9,0: (140.833,119.992,72.2335) #8D7848 srgb(55.2285%,47.0558%,28.3268%)', b'10,0: (90.2724,131.125,60.2996) #5A833C srgb(35.4009%,51.4214%,23.6469%)', b'11,0: (106.475,137.642,86.5564) #6A8A57 srgb(41.7548%,53.9773%,33.9437%)', b'12,0: (110.195,140.638,95.9611) #6E8D60 srgb(43.2136%,55.1522%,37.6318%)', b'13,0: (142.607,163.447,111.984) #8FA370 srgb(55.9243%,64.097%,43.9155%)', b'14,0: (189.553,179.938,116.809) #BEB475 srgb(74.3343%,70.5638%,45.8076%)', b'15,0: (175.093,187.751,137.782) #AFBC8A srgb(68.6641%,73.6278%,54.0322%)' ]
pre-adjust:
[
#1F261F ,
#232E23 ,
#2F4F2F ,
#396335 ,
#455B37 ,
#476C3A ,
#3D5E42 ,
#507249 ,
#5E7551 ,
#8D7848 ,
#5A833C ,
#6A8A57 ,
#6E8D60 ,
#8FA370 ,
#BEB475 ,
#AFBC8A
]
post-adjust:
[
#121612 ,
#5E7551 ,
#8D7848 ,
#5A833C ,
#6A8A57 ,
#6E8D60 ,
#8FA370 ,
#c3c4c3 ,
#4d504d ,
#5E7551 ,
#8D7848 ,
#5A833C ,
#6A8A57 ,
#6E8D60 ,
#8FA370 ,
#c3c4c3
]
niksignh710's abstract wallpaper
pywal:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (20.8093,18.9533,13.5331) #15130E srgb(8.16052%,7.43267%,5.30709%)', b'1,0: (44.9805,24.7977,18.0856) #2D1912 srgb(17.6394%,9.72457%,7.09239%)', b'2,0: (55.6148,33.9961,26.9144) #38221B srgb(21.8097%,13.3318%,10.5547%)', b'3,0: (75.5798,27.4669,21.1245) #4C1B15 srgb(29.6391%,10.7713%,8.28412%)', b'4,0: (101.646,36.2568,28.8444) #66241D srgb(39.8611%,14.2184%,11.3115%)', b'5,0: (120.148,67.463,58.2646) #78433A srgb(47.1168%,26.4561%,22.8489%)', b'6,0: (159.206,43.9922,27.7043) #9F2C1C srgb(62.4338%,17.2519%,10.8644%)', b'7,0: (196.463,57.8016,24.0506) #C43A18 srgb(77.0443%,22.6673%,9.4316%)', b'8,0: (170.202,73.179,51.0623) #AA4933 srgb(66.746%,28.6976%,20.0244%)', b'9,0: (208.716,84.7432,39.7471) #D15528 srgb(81.8494%,33.2326%,15.5871%)', b'10,0: (209.712,85.9689,40.9027) #D25629 srgb(82.24%,33.7133%,16.0403%)', b'11,0: (174.875,96.4047,84.0272) #AF6054 srgb(68.5786%,37.8058%,32.9519%)', b'12,0: (204.942,114.732,83.8366) #CD7354 srgb(80.3693%,44.9928%,32.8771%)', b'13,0: (187.646,130.444,118.977) #BC8277 srgb(73.5866%,51.1543%,46.6575%)', b'14,0: (207.755,136.44,110.366) #D0886E srgb(81.4725%,53.5058%,43.2807%)', b'15,0: (203.202,145.097,133.619) #CB9186 srgb(79.6872%,56.9009%,52.3995%)' ]
pre-adjust:
[
#15130E ,
#AA4933 ,
#D15528 ,
#D25629 ,
#AF6054 ,
#CD7354 ,
#BC8277 ,
#D0886E ,
#CB9186 ,
#AA4933 ,
#D15528 ,
#D25629 ,
#AF6054 ,
#CD7354 ,
#BC8277 ,
#D0886E
]
post-adjust:
[
#0c0b08 ,
#AA4933 ,
#D15528 ,
#D25629 ,
#AF6054 ,
#CD7354 ,
#BC8277 ,
#dfbbae ,
#9c8279 ,
#AA4933 ,
#D15528 ,
#D25629 ,
#AF6054 ,
#CD7354 ,
#BC8277 ,
#dfbbae
]
pywal16:
data from ImageMagick: [ b'# ImageMagick pixel enumeration: 16,1,255,srgb', b'0,0: (20.8093,18.9533,13.5331) #15130E srgb(8.16052%,7.43267%,5.30709%)', b'1,0: (44.9805,24.7977,18.0856) #2D1912 srgb(17.6394%,9.72457%,7.09239%)', b'2,0: (55.6148,33.9961,26.9144) #38221B srgb(21.8097%,13.3318%,10.5547%)', b'3,0: (75.5798,27.4669,21.1245) #4C1B15 srgb(29.6391%,10.7713%,8.28412%)', b'4,0: (101.646,36.2568,28.8444) #66241D srgb(39.8611%,14.2184%,11.3115%)', b'5,0: (120.148,67.463,58.2646) #78433A srgb(47.1168%,26.4561%,22.8489%)', b'6,0: (159.206,43.9922,27.7043) #9F2C1C srgb(62.4338%,17.2519%,10.8644%)', b'7,0: (196.463,57.8016,24.0506) #C43A18 srgb(77.0443%,22.6673%,9.4316%)', b'8,0: (170.202,73.179,51.0623) #AA4933 srgb(66.746%,28.6976%,20.0244%)', b'9,0: (208.716,84.7432,39.7471) #D15528 srgb(81.8494%,33.2326%,15.5871%)', b'10,0: (209.712,85.9689,40.9027) #D25629 srgb(82.24%,33.7133%,16.0403%)', b'11,0: (174.875,96.4047,84.0272) #AF6054 srgb(68.5786%,37.8058%,32.9519%)', b'12,0: (204.942,114.732,83.8366) #CD7354 srgb(80.3693%,44.9928%,32.8771%)', b'13,0: (187.646,130.444,118.977) #BC8277 srgb(73.5866%,51.1543%,46.6575%)', b'14,0: (207.755,136.44,110.366) #D0886E srgb(81.4725%,53.5058%,43.2807%)', b'15,0: (203.202,145.097,133.619) #CB9186 srgb(79.6872%,56.9009%,52.3995%)' ]
pre-adjust:
[
#15130E ,
#2D1912 ,
#38221B ,
#4C1B15 ,
#66241D ,
#78433A ,
#9F2C1C ,
#C43A18 ,
#AA4933 ,
#D15528 ,
#D25629 ,
#AF6054 ,
#CD7354 ,
#BC8277 ,
#D0886E ,
#CB9186
]
post-adjust:
[
#0c0b08 ,
#AA4933 ,
#D15528 ,
#D25629 ,
#AF6054 ,
#CD7354 ,
#BC8277 ,
#c2c2c1 ,
#484845 ,
#AA4933 ,
#D15528 ,
#D25629 ,
#AF6054 ,
#CD7354 ,
#BC8277 ,
#c2c2c1
]
across my tests the color0 came out the same, tho i did take care of running wal -c
between generations of colors, what i did notice is that pywal16 produces a lighter color 7 (and 15) while also producing a darker color 8
for that reason #57 was opened with the corresponding fixes as modifiying the generic adjust function to only darken the color 0 in 40% (to get old pywal behaviour) impacts the other backends that DO depend on the generic adjust giving them an 80% darkening of their color 0.
I switched to your pywal fork and i noticed that background colors are almost pitch black compared to python-pywal i was using before
Is there any way to make pywal16 behave like python-pywal (I used VSCode as a example but this apllies to anything that sues @backgroundcolor including my waybar and rofi presets)
python-pywal package from arch repo
pywal16 installed with pipx