fix empty message on plasma

eylles / pywal16

16 colors fork of pywal

MIT License

157 stars 24 forks source link

fix empty message on plasma #51

Closed Acetylsalicylsaeure closed 3 months ago

Acetylsalicylsaeure commented 3 months ago

sending to /dev/pts/0 leads to a erronious notification on KDE plasma. not breaking, but annoying.

adds a check to not do that when the DE is "plasma", addition of other DEs with the problem welcome

eylles commented 3 months ago

thanks, i've never experienced such an error message on xfce, mate nor awesomewm.

question, does it only happen with /dev/pts/0 or with all /dev/pts/ devices?

Acetylsalicylsaeure commented 3 months ago

added the check just for /dev/pts/0, as referenced here, and that fixed the issue for me. furthermore, looking at /var/log/messages, i find this error message

plasmashell[2757]: org.kde.plasma.notificationmanager: Notification to send to backend contains invalid XML: "Unexpected ''." line 1 col 7

i can only assume that pts/0 is reserved by the root shell for special purposes?

happend on fedora 37, plasma 5 and after updating on fedora 40, plasma 6

eylles commented 3 months ago

okay, merging.