search

eyp / redmine_spent_time

Redmine plugin that improves the spent time functionality.
Other
57 stars 39 forks source link

Added note to install best_in_place. #47

Closed burci closed 10 years ago

burci commented 10 years ago

I don't know if gem install best_in_place is enough.

eyp commented 10 years ago

It isn't better to do a 'bundle install'

burci commented 10 years ago

Hi! You mean:

... git clone https:// github.com/eyp/redmine_spent_time.git then cd redmine_spent_time && bundle install

or something like this? If it is better, i will change the pull request, the only missing part was in document somehow install the best_in_place gem.

eyp commented 10 years ago

Yes, last week I was testing the plugin on a Redmine 2.4.1 installed from scratch and I realized that the installation instruction of the plugin missed that step. As the plugin has a Gemfile file with the gem "best_in_place" line, simply doing bundle install will install the gem.

But I didn't update anything in the README because I was working on other requests. Change the line for a bundle install and that's all.

eyp commented 10 years ago

I forgot to give thanks to you.

burci commented 10 years ago

I changed the pull request, do you think it is correct now?

eyp commented 10 years ago

Perfect... well, after the merge I've fixed a typo :).

Thank you Peter.

burci commented 10 years ago

Thx!