eyra / mono

Next platform repo
https://eyra.co
GNU Affero General Public License v3.0
7 stars 4 forks source link

Data uploaded in preview mode is actually stored #888

Closed TjerkNan closed 3 months ago

TjerkNan commented 3 months ago

Describe the bug When uploading data in preview mode, the data should not actually be donated and stored in storage. When data is donated in preview mode and storage is visited, it is observed that a file is donated.

To Reproduce Steps to reproduce the behavior:

  1. create data donation study
  2. create storage (local)
  3. Add data donation step in workflow with appropriate zip
  4. Open preview
  5. Donate data in preview
  6. Go to storage card
  7. Observe donated data in preview

Expected behavior No data to be stored when data donated in preview.

Screenshots Screenshot 2024-06-26 at 23 18 37

Desktop (please complete the following information):

mellelieuwes commented 3 months ago

@TjerkNan this is by design. Creators can test everything before publish. This becomes more important when we introduce licenses.

Solution for possible confusion:

  1. Creators can delete all files before publish. This feature will be implemented soon. See: #891
  2. I will change the participant id to "preview" iso a real id so the files can always be recognized.

I will use this ticket to implement the second solution

mellelieuwes commented 3 months ago

When starting preview flow, the participant will be set "preview". This way the creator can always distinguish real donations from testing.

Image

TjerkNan commented 3 months ago

Seems to work, I notice participant=preview