eyra / mono

Monorepo (used by Next Platform)
https://eyra.co
GNU Affero General Public License v3.0
7 stars 2 forks source link

[Storage] CMS: monitor metrics #898

Closed mellelieuwes closed 2 weeks ago

mellelieuwes commented 3 weeks ago

Implement the following metrics:

  1. Number of store requests
  2. Nr of bytes written to storage.

Note: If the storage is emptied (see: #891) the monitor metrics are not reset. So 2 is this a sum of the total written bytes (traffic volume) not the current stored bytes.

mellelieuwes commented 3 weeks ago

Image

mellelieuwes commented 3 weeks ago

@TjerkNan for the future:

  1. What extra usage metrics would be useful for a data storage?
  2. Can we set thresholds on the metrics to raise awareness by giving them a color (orange or red). Not sure if this applicable since the Monitor is not for us but for the creator.
TjerkNan commented 3 weeks ago

Maybe add: Total storage used in GB.

Just my opinion:

mellelieuwes commented 2 weeks ago

@TjerkNan In general Monitor is based on system events. Actual data is not part of the Monitor.

For storage we currently have the following metrics:

If the files in the storage are deleted, the events are not reset.

In general the Monitor is (only) designed for:

  1. Give trust when seeing activity
  2. Taking actions if something is not going as expected

For storage the Monitor is not really necessary. But to be consistent with other CMS pages it is added.

mellelieuwes commented 2 weeks ago

See the follow up improvements:

  1. 918

  2. 917

TjerkNan commented 2 weeks ago

@emielvdveen #918 tested, keep this open for #917 when ready

TjerkNan commented 2 weeks ago

as discussed this can be closed