search

eyre-rs / color-eyre

Custom hooks for colorful human oriented error reports via panics and the eyre crate
Other
958 stars 57 forks source link

add config option to disable location section #106

Closed Emilgardis closed 2 years ago

Emilgardis commented 2 years ago

resolves #105

I'm not sure how to handle the panic hook. I think it makes sense to always display the location even if we've set the config to false.

If this is unexpected (I think it isn't), it should be possible to implement by adding a field to DefaultPanicMessage

Emilgardis commented 2 years ago

hmm, that failure is annoying. Can fix with a cfg on the test file I think

Emilgardis commented 2 years ago

fixed the build error, remembered I had this pr and figured I'd fix it while on the phone, using dev.github.com seems promising, but it's not too great 😅

yaahc commented 2 years ago

I'm sorry for leaving this sitting around for so long. I'll go back and fix the new clippy warnings in a followup, thank you again for the PR!

Emilgardis commented 2 years ago

No worries! I know you're busy :D