search

eyurtsev / fcsparser

A python parser for reading fcs files supporting FCS 2.0, 3.0, 3.1
MIT License
74 stars 45 forks source link

Support for loading in-memory files #10

Closed OMantere closed 7 years ago

OMantere commented 7 years ago

This PR adds a small wrapper for np.fromfile to allow loading of BytesIO wrapped FCS files by using a new call FCSParser.fromfile(). Also abstracting the dataframe constructing code to a method to enable getting that from the FCSParser object.

eyurtsev commented 7 years ago

Thanks for the PR -- I'll try and review within a few days -- Could you fix the accidental commit in the tests file? It's causing the tests to fail

OMantere commented 7 years ago

@eyurtsev Sorry about that. Should be fixed now. Thanks for taking the time to review.

OMantere commented 7 years ago

@eyurtsev Can we push the latest version to PyPi? Thanks.

eyurtsev commented 7 years ago

working on it now -- sorry for delay -- as usual totally blanked out

eyurtsev commented 7 years ago

Upload to pypi let me know if you bump into any issues.

FYI -- I changed the dataframe method to a property, so you may need to update some of your code