eyurtsev / fcsparser

A python parser for reading fcs files supporting FCS 2.0, 3.0, 3.1
MIT License
74 stars 45 forks source link

Add tests for multi tube file parsing to pr #45

Closed CaRniFeXeR closed 1 year ago

CaRniFeXeR commented 1 year ago

I swapped the fcs file for multi-tube testing and added a test that ensures that each tube loads something different. The issue raised by @eyurtsev that multiple tubes have the same values seems only specific to the previously used fcs file.

I switched to use the same fcs file as in CytoFlow see: https://github.com/cytoflow/cytoflow/tree/master/cytoflow/tests/data/instruments. As well as added a similar test as in https://github.com/cytoflow/cytoflow/blob/master/cytoflow/tests/test_import.py#L104

eyurtsev commented 1 year ago

Thank you