BD facs diva support - Githubissues

eyurtsev / fcsparser

A python parser for reading fcs files supporting FCS 2.0, 3.0, 3.1

MIT License

73 stars 43 forks source link

BD facs diva support #46

Closed CaRniFeXeR closed 1 year ago

CaRniFeXeR commented 1 year ago

BD facs diva devices only have channel_name_s set for some but not all channels. If not present for all channels fcsparser fallbacks to the channel_names_n.

This pull request includes two main adaptations:

Using channel_names_n as a fallback for channels without a value in channel_names_s
Puts both $PnN and $PnS as columns into the metadata dataframe

All adaptations have corresponding unit tests

eyurtsev commented 1 year ago

Comandeering to resolve conflicts

eyurtsev commented 1 year ago

@CaRniFeXeR thanks for the PR! I added CI to run to make sure unit-test are running as part of the PR. Would you be able to address the failing tests and add back missing tests?