ezKEa / aagl-gtk-on-nix

Run an-anime-game-launcher GTK version on Nix/NixOS!
GNU General Public License v3.0
72 stars 10 forks source link

Add nix flake #16

Closed yavko closed 1 year ago

yavko commented 1 year ago

Who doesn't love nix flakes?

ezKEa commented 1 year ago

Hi! thanks for the PR! I noticed your flake includes the only NixOS module, and not the an-anime-game-launcher package itself. While this works fine for NixOS users who just want to use the launcher through the module, I feel a proper solution would have the package declared in the outputs.packages attribute and passed on to the module (rather than the module importing default.nix as it does now), which would also allow users to build the package from the flake. Perhaps this repo being fully flake-based with flake-compat for legacy compatibility would be best.

In any case, I plan on flakifying my system soon so I'll be able to give proper consideration to how this should be done then. For the time being, this should be good to merge if you add the launcher (and its unwrapped version) to the flake's outputs.packages attribute. Thanks!

yavko commented 1 year ago

I at first was thinking of also adding a overlay and packages, but in the end decided not too. If you want i can rewrite it completely to be built around flakes.

ezKEa commented 1 year ago

It will be fine if you just add a packages attribute with the launcher and its unwrapped version (like in the current default.nix). I can set up flake-compat at a later time.

yavko commented 1 year ago

Ight, I'll add it in like an hour, though I'm willing to add flake-compat support if you want since I've done it before.

yavko commented 1 year ago

Sorry I had something came up, and wasn't able to do it yesterday as I said, anyway here it is!