ezSQL / ezsql

PHP class to make interacting with a database ridiculusly easy
http://ezsql.github.io/ezsql
GNU Lesser General Public License v3.0
866 stars 291 forks source link

Tests for JOIN needs fixing #200

Closed TheTechsTech closed 3 years ago

TheTechsTech commented 3 years ago

@dpDesignz I been working on getting library updated for PHP 8, and discovered some errors show only up under it.

The tests for the Joins has issues that exists regardless of the PHP version.

In: https://github.com/ezSQL/ezsql/blob/863c1849aa020c1dbb2d6695b90382b68dc7bf57/tests/pdo/pdo_mysqlTest.php#L288 https://github.com/ezSQL/ezsql/blob/863c1849aa020c1dbb2d6695b90382b68dc7bf57/tests/pdo/pdo_pgsqlTest.php#L210 https://github.com/ezSQL/ezsql/blob/863c1849aa020c1dbb2d6695b90382b68dc7bf57/tests/pdo/pdo_sqliteTest.php#L239 https://github.com/ezSQL/ezsql/blob/863c1849aa020c1dbb2d6695b90382b68dc7bf57/tests/pdo/pdo_sqlsrvTest.php#L214

The second tables created is not receiving any inserted data, it's going to first table only still, and should have failed, no test for real insertion check.