search

eza-community / eza.rocks

EZA Rocks, on the Wolrld Wide Interwebs
https://eza.rocks/
GNU Affero General Public License v3.0
5 stars 4 forks source link

YAML icon missing even with a NerdFont patched font #10

Open quicknir opened 6 months ago

quicknir commented 6 months ago

I'll start off by saying that surprisingly, I can't find any discussion about the necessity of installing fonts to make icons work on either the github page, or the website. Maybe I missed it. I was able to find such a discussion on the old exa website: https://the.exa.website/features/icons. If I did not miss it, then I'd suggest something about this be added, to both the github and the website, as it doesn't seem completely obvious to everyone that this would be needed. I mention this because when I saw my YAML icon was missing, the first thing I did was look to see if there were any "officially" sanctioned fonts that were known to contain all the icons.

Even with a NerdFont installed though (specifically JetbrainsMono, patched by NF), I don't see a proper icon for yaml files. Is there something wrong with my installation? Is there a workaround?

quicknir commented 6 months ago

Edit: maybe I'm actually wrong. What I'm seeing is an exclamation mark: it didn't really occur to me that the exclamation mark was the intended icon for yaml files as I wasn't aware of any connection there. I assumed it was some kind of placeholder. Maybe it would help if there were a screenshot or a few of them to show what each file icon "should" look like.

MartinFillon commented 6 months ago

Hello this is indeed the current intended icon, if you think this should be change feel free to make a pr to propose one.

quicknir commented 6 months ago

I would probably just suggest to use the icon for either toml or json instead. Unless there's a connection between exclamation marks and YAML I'm not aware of. YAML is a json superset so {} is reasonable; or, YAML is typically used to hold configuration much like TOML so a gear is fine as well. It seems like at least some other projects use the gear: https://www.reddit.com/r/vim/comments/xumt9k/icons_all_pink_in_nerdtree_using_firacode_nerd/. Alternately, it might be nice to ask the NerdFont people to just have a proper YAML file icon which would be a lot clearer: https://uxwing.com/yaml-file-icon/ (more similar to the markdown approach).