search

eza-community / eza

A modern alternative to ls
https://eza.rocks
MIT License
10.7k stars 184 forks source link

bug: `EZA_GRID_ROWS` does not have any effect on grid details view #1044

Closed LeoniePhiline closed 2 weeks ago

LeoniePhiline commented 1 month ago

This is a follow-up to https://github.com/eza-community/eza/issues/66#issuecomment-2198567463 and the discussion following it.

On eza, main branch, EZA_GRID_ROWS does not effectively prevent a grid view from being rendered if the threshold of configured number of rows is not reached.

The intention of EZA_GRID_ROWS is to force a details list view if there are only few items in the result set.

A fix is implemented in https://github.com/eza-community/eza/pull/1043.

cafkafk commented 1 month ago

However, from a functionality perspective, as an end user I would expect this to apply to plain EZA_GRID_ROWS=1234 eza as well, without involvement of details views.

To be perfectly honest I'm extremely sick from covid so I can't really be of much help rn, but I vague get the sense that the current intention behind EZA_GRID_ROWS (whether it works or not) could be done differently, and maybe should be...

cafkafk commented 1 month ago

fwiw from the man page:

   EZA_GRID_ROWS
       Limits the grid-details view (`eza --grid --long') so it’s only  activated  when
       at least the given number of rows of output would be generated.

       With  widescreen  displays,  it’s  possible  for  the grid to look very wide and
       sparse, on just one or two lines with none of the columns lining up.  By  speci‐
       fying  a  minimum  number of rows, you can only use the view if it’s going to be
       worth using.
LeoniePhiline commented 1 month ago

To be perfectly honest I'm extremely sick from covid

I wish you the best! Get well soon! ❤️‍🩹