Closed allaboutevemirolive closed 1 month ago
Thanks for the PR!
Personally I like it, it makes sense to me. I'm for merging if everyone else is.
Do we need to worry about the failed FreeBSD check?
this looks like the same exact issue from last week. I thought we merged a fix for this?
EDIT: yup it was #929
OK I see the other issue is the tryCMD test output. Because the output is different (space added) those tests are going to have to be adjusted. @cafkafk or @MartinFillon would know the procedure here with new output.
As per the tests, just run
just idump
then dojust itest
you will need a working nix shell, andJust
Hi @MartinFillon, just to confirm, do I need to run those tests on my local machine?
I ran just build-release test-release
, but the command just idump
followed by just itest
is not working.
yup on your local machine and look for any ptests_file updated other can be dicarded iirc
I'm not sure why cicd didn't pass. Here I put updated files after run idump
.
Then I run git add tests/ptests/*
to only add ptest.
Gonna take a look at your branch if you allow me
This PR improves branch visibility by adding
space
immediately in theascii_art
method rather than deciding whether to add space or not at runtime. This branch visibility is based on how the original Tree built the branch to make it look better.Before:
After: