search

ezaquarii / vpn-at-home

1-click, self-hosted deployment of OpenVPN with DNS ad blocking sinkhole
GNU General Public License v3.0
1.11k stars 90 forks source link

add docker-compose #27

Closed LukasWerfel closed 5 years ago

LukasWerfel commented 5 years ago

hi @ezaquarii, really cool project, I like it a lot!

I saw that you use docker (awesome!) and use this helper script docker_run. I realized that that could also be done in docker-compose, and was curious if you would be willing to accept a contribution.

This would also make it easier to use docker in development, and then possible new contributor would need to worry about all the prerequisites.

I am fairly new to OS, so I would be excited to work on this with your help. I started already in this PR, but this is WIP. You can try it with docker-compose up.

Let me know what you think!

ezaquarii commented 5 years ago

Hi,

Thank you for the effort.

Yes, generally I'm keen on accepting contributions in this area, as the docker_run script is more a testing tool than a production-grade solution - I'm not using docker right now and I was waiting for docker users to come up with an expected use case before sinking my own resources here.

Let me reflect on your PR after Xmas Eve heat drops a bit.

LukasWerfel commented 5 years ago

I think for now #28 is more worth pursuing