ezaquarii / vpn-at-home

1-click, self-hosted deployment of OpenVPN with DNS ad blocking sinkhole
GNU General Public License v3.0
1.11k stars 90 forks source link

[frontend] Add autoscroll to deployment progress dialog #33

Closed arpreq closed 5 years ago

arpreq commented 5 years ago

Attempt to close #26

A lot more difficult than I first thought it would be. The $nextTick call is required because updates from calling this.output.push() happen asynchronously(?) and the scrolling would take place before the last item was added to the dialog. This way, the scroll is done right after each item is added.

Let me know if I did this correctly, as this is still all very new to me. Thanks.

arpreq commented 5 years ago

Title updated

ezaquarii commented 5 years ago

Unfortunately I had to back out this change. It does not work:

  1. Output prints only "ok: hostname" - significant portion of output is lost somehow.
  2. Scrolling is unreliable - after 2-3 scrolls it stops until I scroll again to the bottom.