search

ezbz / gitlabber

Gitlabber - clones or pulls entire groups tree from gitlab
MIT License
472 stars 78 forks source link

add parameter --path to use project path instead of project name #39

Closed ziegenberg closed 3 years ago

ziegenberg commented 3 years ago

Make it possible to generate folder names based on group and project path instead of group and project name.

Possible FIX #25 and FIX #38.

ziegenberg commented 3 years ago

Tests are still missing.

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (d8e1c67) into master (ef989b1) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   95.56%   95.62%   +0.05%     
==========================================
  Files           8        8              
  Lines         316      320       +4     
==========================================
+ Hits          302      306       +4     
  Misses         14       14
Impacted Files Coverage Δ
gitlabber/cli.py 94.44% <100.00%> (+0.07%) :arrow_up:
gitlabber/gitlab_tree.py 97.67% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef989b1...d8e1c67. Read the comment docs.

TheKangaroo commented 3 years ago

@ezbz is this going to be merged soon? Thats exactly what I need 😍

ezbz commented 3 years ago

This https://github.com/ezbz/gitlabber/pull/43 replaces this PR, it is more aligned with project code using enums rather than booleans to allow expanding future values and doesn't add any more unnecessary fields to the data model (either path or name are used not both so need to cache the values in the model when path is not used)

ziegenberg commented 3 years ago

It's nice to see to get this resolved. If you'd asked, I would have gladly adapted my PR.

Are going to release this as 1.1.2?

ezbz commented 3 years ago

Are going to release this as 1.1.2?

Released in 1.1.2 https://raw.githubusercontent.com/ezbz/gitlabber/master/CHANGELOG.md

I have to work up the contribution guidelines, will gladly accept help moving forward