search

ezbz / gitlabber

Gitlabber - clones or pulls entire groups tree from gitlab
MIT License
472 stars 78 forks source link

change method from http to https #40

Closed ziegenberg closed 3 years ago

ziegenberg commented 3 years ago

It's merely cosmetic, but HTTPS would be the more common method over HTTP.

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (1343a8a) into master (ef989b1) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files           8        8           
  Lines         316      316           
=======================================
  Hits          302      302           
  Misses         14       14
Impacted Files Coverage Δ
gitlabber/method.py 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef989b1...1343a8a. Read the comment docs.

ezbz commented 3 years ago

This parameter specifies transport method not security level this change is misleading because it doesn't really affect the security level. Gitlabber respects the Gitlab API semantics https://docs.gitlab.com/ee/api/projects.html which use ssh_url_to_repo and http_url_to_repo so the current implementation is correct