search

ezbz / gitlabber

Gitlabber - clones or pulls entire groups tree from gitlab
MIT License
472 stars 78 forks source link

Reduce the number of scanned projects when possible #71

Closed Crocmagnon closed 3 years ago

Crocmagnon commented 3 years ago

Closes #68

The current implementation doesn't add any option and piggybacks on --include.

When there's only one include and it looks like a top level group, use the search feature of gitlab instead of blindly list all groups, subgroups and projects.

ezbz commented 3 years ago

The fact that this works only for a single include while gitlabber supports multiple includes is an issue waiting to be opened. I want to take another shot at this, either remove the support for multiple includes (and redact from current functionality) or have this support multiple include paths by executing a query with search per include element and merging the results.

I'd rather not deliver incomplete functionality when applying this performance optimization.

Crocmagnon commented 3 years ago

Do you know whether people tend to use it with multiple includes ? Is this a feature that's worth supporting ? That would help deciding whether to do multiple searches or removing the support for multiple includes 🙂

Crocmagnon commented 3 years ago

Also, couldn't it justâ„¢ be documented? Like "we know this currently works for only one include but we welcome pull requests to support multiple ones"?

ezbz commented 3 years ago

Closing this as it degrades documented behavior