ezcommunity / ezupgrade

GNU General Public License v2.0
10 stars 3 forks source link

Upgrading from 4.4.0 to 4.5.0 generates database inconsistencies #7

Closed jpingo closed 12 years ago

jpingo commented 13 years ago

After upgrading 4.4.0 to 4.5.0, if we check for database consistency in admin interface there are warnings present

nmeirik commented 13 years ago

Can you please specify the inconsitencies that are listed?

jpingo commented 13 years ago

Hi There!

See attached file with database upgrade check...

Best Regards Joo Pingo

2011/5/25 nmeirik < reply@reply.github.com>

Can you please specify the inconsitencies that are listed?

Reply to this email directly or view it on GitHub: https://github.com/ezsystems/ezupgrade/issues/7#comment_1236382

nmeirik commented 13 years ago

Hi Joo Pingo,

I'm not sure if the attachment was included. Could you please cut and paste the contents?

Thanks in advance!

jpingo commented 13 years ago

Hi I found out what is wrong... The name of the database in settings is not updated during the upgrade. ezupgrade asks for this: "The file 'settings/siteaccess/eng/site.ini.append.php' need to be altered to use database 'ezp440sna pshot_450' and then clear the cache.Do you want to continue? (y/n) [y] y" Even though I answer "y", the database name is not changed from to "ezp440snapshot_450". It remains "ezp440snapshot" So if I change the database settings manually ( and thereby actuall use the correct database), the database upgrade check succeeds....

ghost commented 13 years ago

Hi Joo,

The notice you're referring to is meant to be an instruction to do this manually. I can see how this can be unclear to new users of ezupgrade, and we will consider changing the wording of this notice to be more clear about this.

vidarl commented 13 years ago

Hi Helge Both me and Joao understood the message "The file 'settings/siteaccess/eng/site.ini.append.php' need to be altered to use database 'ezp440sna pshot_450' and then clear the cache.Do you want to continue? (y/n) [y] " as ezupgrade would fix the ini file, not that you had to do it manually. IMHO, either ezupgrade should be fixed so that the ini file is updated automatically, or the message has to be changed. Suggestion: These ini files needs to be altered manually after ezupgrade has completed:

cgjengedal commented 12 years ago

This commit emphasizes on the manual job: https://github.com/ezsystems/ezupgrade/commit/e3683d3fd54150f4146f658e8b31d8b46aa7c40a