search

ezcommunity / ezupgrade

GNU General Public License v2.0
10 stars 3 forks source link

Mysqli message shown even if installation already in mysqli #8

Closed jpingo closed 12 years ago

jpingo commented 13 years ago

After runing the script the message show that you should change mysql to mysqli support even if the former installation is already using mysqli... this happened in 4.4.0 -> 4.5.0 upgrade

nmeirik commented 13 years ago

You are correct. eZ Upgrade does not check whether or not mysqli is already specified. Hence, this is marked as a feature request.

Variations of fixing this issue could be:

  1. Make the message more generic (ensure you are using mysqli)
  2. Check to see if mysqli is already in use
  3. Change any occurence of mysql to mysqli. This would probably require a prompt beforehand to ensure that this is something the user actually wanted (and had support for).