search

ezeAng / pe

0 stars 0 forks source link

User allowed to add or edit rate to be larger than 1000000 #5

Open ezeAng opened 1 year ago

ezeAng commented 1 year ago

User allowed to edit or add rate to be larger than 1000000 even though it is specified that they should not be allowed to do so. There should be an error message or exception preventing that.

bug4.png

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

editing an event's rate to above 1000000

Although the team mentioned that the rate should be less than 1 million. This is not specified in the edit command section

When the user accidentally types a value more than that, the UI shows 1.0E7 for example which is not intuitive for the user.

Input: edit 1 r/10000000

Screenshot 2023-04-14 at 2.57.02 PM.png

[original: nus-cs2103-AY2223S2/pe-interim#2884] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The restrictions on the rates is already mentioned in the creation of events and it is implied that the restrictions will hold for all events even during an edit of any events. Hence, this is a bug that is not within scope.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** There is no clear warning or error handling when the input is above the desired limit, which suggests implicitly that there is no limit, users would have to fine-read the guides to find out that there was an implicit limit.
## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** There is no clear warning or error handling when the input is above the desired limit, which suggests implicitly that there is no limit. This is not a documentation bug since the team made it clear in the guides that there was a limit, however it is not enforced. So this is functionality bug of the application and not that the documentation was unclear.