search

ezeAng / pe

0 stars 0 forks source link

User allowed to edit end date to be earlier than start date #8

Open ezeAng opened 1 year ago

ezeAng commented 1 year ago

User allowed to edit end date to be earlier than start date. Try editing an event, to end earlier than the start, and there is no error.

Screen Shot 2023-04-14 at 15.04.11 PM.png

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

End Date of an event allowed to be before the Start Date

Description

Missing validation check for whether dates are chronologically valid.

Steps to reproduce

  1. Enter the command newevent n/DJ at wedding r/100 a/311, Clementi Ave 2, #02-25 ds/11-03-2023 11:00 de/11-02-2023 17:00 t/friends t/dj. The start month in this case is March, and the end month is February.

  2. The event is successfully added.

image.png

[original: nus-cs2103-AY2223S2/pe-interim#3220] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is already stated in the DG where it will be planned for future enhancements.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** The issue with the end date being possibly earlier than the start date is not the biggest issue, but could cause repercussions down the road, confusion and even more so when there is a feature that filters events by start data. There are many instances that the team has placed an issue to be a "planned enhancement". If that is the case we could all submit a half-working application and place the other half that has yet to work under a "planned enhancement".