search

ezekielaquino / Marquee3000

Marquees for the new millenium
https://ezekielaquino.com/2019/marquee
MIT License
438 stars 81 forks source link

Destroy latest instance on init #25

Closed arnasziedavicius closed 4 years ago

arnasziedavicius commented 4 years ago

Related to issue https://github.com/ezekielaquino/Marquee3000/issues/3

ezekielaquino commented 4 years ago

Hey @arnasziedavicius ! so the use case (hence the bug), just to understand it clearly, is when re-initialising after destroying an instance?

arnasziedavicius commented 4 years ago

Hi @ezekielaquino, yes, there seems to be no way to destroy the instance at the moment and it keeps initialising on top itself resulting in increase of speed (i.e. on hot module replacement).

ezekielaquino commented 4 years ago

Merged! (super late) many many thanks for the contribution @arnasziedavicius!