search

ezekielaquino / Marquee3000

Marquees for the new millenium
https://ezekielaquino.com/2019/marquee
MIT License
438 stars 81 forks source link

Reverse is not working #29

Open MathiasGmeiner opened 4 years ago

MathiasGmeiner commented 4 years ago

I had to change this line 88 to

const direction = this.reverse == 'true' ? -1 : 1;

ghost commented 4 years ago

Wait, this does not solve the issue. It moves backward, but only once. After that it's blank.

chrisallick commented 4 years ago

Was never able to get that option working. But if you just go to line 27 in marquee3k.js and hard code it: this.reverse = false; at least it will reverse.

fritzlaszlo commented 3 years ago

a quick "workaround" for this bug: the dataset itself already triggers the direction change. no matter if its true or false. see here the original codepen without dataset: https://codepen.io/ezekielaquino/pen/jwOMqV see here with reverse dataset: https://codepen.io/flweb/pen/xxOjrLR

brdavs commented 1 year ago

This is great, but the minified version does not contain the fix.

dollseb commented 1 year ago

The min.js still does not contain the fix. Movement is always reversed. Changing the dataset has no effect.