search

ezekielchentnik / preact-pwa

Super fast progressive web app with small footprint & minimal dependancies
https://preact-pwa-yfxiijbzit.now.sh/
MIT License
511 stars 45 forks source link

mkdirp for folder creation #3

Closed bstavroulakis closed 7 years ago

bstavroulakis commented 7 years ago

I tried to build this project on a windows machine but was getting an error related to the mkdir command. It looks like there is an issue with the mkdir, npm and windows and the mkdirp library fixes this issue.

bstavroulakis commented 7 years ago

Without the '&' or '&&' I get 'node' is not recognized as an internal or external command.

Will the && work for you?

packageupdates
ezekielchentnik commented 7 years ago

@bstavroulakis make sure to pull down latest

https://github.com/ezekielchentnik/preact-pwa/blob/master/build.js#L103

mkdir is no longer in package.json, but in build.js (it always was in build.js, there was duplicate code). we should definately make sure build.js is compatible for windows. do you mind addressing? cheers.