ezet / evelib

Eve Online Library.NET is an open source C# wrapper for CCPs Eve Online API and other popular Eve Online APIs.
Apache License 2.0
72 stars 36 forks source link

ApiKey keyID is long, CreateCharacter keyID is int #105

Open DoogeJ opened 7 years ago

DoogeJ commented 7 years ago

As said in the title:

ApiKey(long keyId, string vCode)

EveXml.CreateCharacter(int keyId, string vCode, long characterId)

These types are not compatible.

ezet commented 7 years ago

I realize this isn't ideal, but the types should still be compatible? The conversion is from int to long, which shouldn't cause any issues ? Please describe what you mean by not compatible.

DoogeJ commented 7 years ago

Conversion works yes and doesn't cause issues. I think it just looks messy. :)