ezet / evelib

Eve Online Library.NET is an open source C# wrapper for CCPs Eve Online API and other popular Eve Online APIs.
Apache License 2.0
71 stars 36 forks source link

Zkillboard FinalBlow bool convert bug #42

Closed ezet closed 9 years ago

ezet commented 9 years ago

var api = new ZKillboard(); var options = new ZKillboardOptions(); options.Limit = 1; options.WSpace = true; try { ZkbResponse response = api.GetKills(options); } catch (Exception ex) { }

This always throws a Newtonsoft.Json.JsonSerializationException "Error converting value \"1\" to type 'System.Boolean'. Path '[0].attackers[0].finalBlow', line 1, position 642." I've dug into it, & it seems that the deserializer should be setting the property "FinalBlowString" of the "ZkbAttacker" object (which then sets the bool "FinalBlow", but something isn't mapping "finalBlow" in the Json to the DataMember "finalBlow" (which is attached to the property "FinalBlowString"). Does anyone else see this, or have any pointers?

ezet commented 9 years ago

Fixed.