search

ezet / stripe-sdk

A simple and flexible Stripe library for Flutter with complete support for SCA and PSD2.
https://pub.dev/packages/stripe_sdk
Other
137 stars 137 forks source link

card_expiry_form_field - Next Input Issue With onFieldSubmitted #113

Closed RtypeStudios closed 3 years ago

RtypeStudios commented 3 years ago

I've noticed on the CardExpiryFormField when clicking next it is skipping over any field that follows. This appears to be due to a change Flutter made to "TextInputAction.next" and the line ""FocusScope.of(context).nextFocus()". Which effective is cause next to happen twice.

Removing this line, fixes the issue: onFieldSubmitted: (value) => FocusScope.of(context).nextFocus()

There is a stack overflow about it here: https://stackoverflow.com/questions/64227030/focusscope-nextfocus-unexpectedly-skips-one-or-more-textformfields

If you think "onFieldSubmitted: (value) => FocusScope.of(context).nextFocus()" just needs to be removed, happy to submit a PR to do it. Otherwise happy to discuss a solution.

Thanks for a great library BTW.

ezet commented 3 years ago

Will fix this for next release

On Wed, Feb 3, 2021, 02:33 RtypeStudios notifications@github.com wrote:

I've noticed on the CardExpiryFormField when clicking next it is skipping over any field that follows. This appears to be due to a change Flutter made to "TextInputAction.next" and the line ""FocusScope.of(context).nextFocus()". Which effective is cause next to happen twice.

Removing this line, fixes the issue: onFieldSubmitted: (value) => FocusScope.of(context).nextFocus()

There is a stack overflow about it here:

https://stackoverflow.com/questions/64227030/focusscope-nextfocus-unexpectedly-skips-one-or-more-textformfields

If you think "onFieldSubmitted: (value) => FocusScope.of(context).nextFocus()" just needs to be removed, happy to submit a PR to do it. Otherwise happy to discuss a solution.

Thanks for a great library BTW.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ezet/stripe-sdk/issues/113, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQOQ67UO6ZG6KBZWXQHCLS5CRXFANCNFSM4W76QEWQ .

RtypeStudios commented 3 years ago

Great thank you!

If you give me instructions on how you want it fixed, I can give it a try and submit a PR :)